All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Wolfram Sang <wsa@the-dreams.de>, NeilBrown <neilb@suse.de>
Cc: linux-omap@vger.kernel.org,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Wolfram Sang <wsa@sang-engineering.com>
Subject: Re: [PATCH] ARM: OMAP2+: don't try to register the main clock twice.
Date: Fri, 11 Apr 2014 18:33:53 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.02.1404111829520.14347@utopia.booyaka.com> (raw)
In-Reply-To: <1396007435-20100-1-git-send-email-wsa@the-dreams.de>

Hi Wolfram, Neil,

On Fri, 28 Mar 2014, Wolfram Sang wrote:

> From: NeilBrown <neilb@suse.de>
> 
> If omap_device_alloc is given 2 or more "struct omap_hwmod" it will try
> to register the 'main_clk' of each of them with the same alias - "fck" -
> against the same device.  This fails. So to avoid a warning, don't even
> try.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>
> [wsa: ported to top-of-tree]
> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>

What devices and hwmods cause this warning on AM335x?   Ideally, there 
should only be one hwmod per device.  Usually when multiple hwmods are 
stacked up for a device, it means that something isn't right - either the 
hwmod data, or the device driver itself. 

In the specific context of this patch, the problem would be: what if the 
two hwmods have different main_clk entries?  Which one should be 
associated with the "fck" alias?


- Paul

  reply	other threads:[~2014-04-11 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 11:50 Wolfram Sang
2014-04-11 18:33 ` Paul Walmsley [this message]
2014-04-17  8:55   ` Wolfram Sang
2014-05-07 23:20     ` Paul Walmsley
2014-05-08  7:02       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1404111829520.14347@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tony@atomide.com \
    --cc=wsa@sang-engineering.com \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH] ARM: OMAP2+: don'\''t try to register the main clock twice.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.