From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753289AbaEVCvS (ORCPT ); Wed, 21 May 2014 22:51:18 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:40844 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbaEVCvN (ORCPT ); Wed, 21 May 2014 22:51:13 -0400 Date: Wed, 21 May 2014 19:51:11 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Vlastimil Babka cc: Andrew Morton , Hugh Dickins , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim , Mel Gorman , Joonsoo Kim , Bartlomiej Zolnierkiewicz , Michal Nazarewicz , Naoya Horiguchi , Christoph Lameter , Rik van Riel Subject: Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages In-Reply-To: <5379D99E.1020302@suse.cz> Message-ID: References: <1399464550-26447-1-git-send-email-vbabka@suse.cz> <1399464550-26447-2-git-send-email-vbabka@suse.cz> <5379D99E.1020302@suse.cz> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-1088296400-1400727068=:13243" Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-1088296400-1400727068=:13243 Content-Type: TEXT/PLAIN; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 19 May 2014, Vlastimil Babka wrote: > Fix a (spurious) build warning: > > mm/compaction.c:860:15: warning: ‘next_free_pfn’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > Seems like the compiler cannot prove that exiting the for loop without updating > next_free_pfn there will mean that the check for crossing the scanners will > trigger. So let's not confuse people who try to see why this warning occurs. > > Instead of initializing next_free_pfn to zero with an explaining comment, just > drop the damned variable altogether and work with cc->free_pfn directly as > Nayoa originally suggested. > s/Nayoa/Naoya/ > Suggested-by: Naoya Horiguchi > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes --531381512-1088296400-1400727068=:13243-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by kanga.kvack.org (Postfix) with ESMTP id 79D296B0036 for ; Wed, 21 May 2014 22:51:14 -0400 (EDT) Received: by mail-pb0-f53.google.com with SMTP id md12so1997185pbc.26 for ; Wed, 21 May 2014 19:51:14 -0700 (PDT) Received: from mail-pa0-x236.google.com (mail-pa0-x236.google.com [2607:f8b0:400e:c03::236]) by mx.google.com with ESMTPS id vx5si31593111pab.104.2014.05.21.19.51.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 May 2014 19:51:13 -0700 (PDT) Received: by mail-pa0-f54.google.com with SMTP id bj1so1988742pad.41 for ; Wed, 21 May 2014 19:51:13 -0700 (PDT) Date: Wed, 21 May 2014 19:51:11 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages In-Reply-To: <5379D99E.1020302@suse.cz> Message-ID: References: <1399464550-26447-1-git-send-email-vbabka@suse.cz> <1399464550-26447-2-git-send-email-vbabka@suse.cz> <5379D99E.1020302@suse.cz> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-1088296400-1400727068=:13243" Content-ID: Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , Hugh Dickins , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim , Mel Gorman , Joonsoo Kim , Bartlomiej Zolnierkiewicz , Michal Nazarewicz , Naoya Horiguchi , Christoph Lameter , Rik van Riel This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-1088296400-1400727068=:13243 Content-Type: TEXT/PLAIN; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 19 May 2014, Vlastimil Babka wrote: > Fix a (spurious) build warning: > > mm/compaction.c:860:15: warning: a??next_free_pfna?? may be used uninitialized in this function [-Wmaybe-uninitialized] > > Seems like the compiler cannot prove that exiting the for loop without updating > next_free_pfn there will mean that the check for crossing the scanners will > trigger. So let's not confuse people who try to see why this warning occurs. > > Instead of initializing next_free_pfn to zero with an explaining comment, just > drop the damned variable altogether and work with cc->free_pfn directly as > Nayoa originally suggested. > s/Nayoa/Naoya/ > Suggested-by: Naoya Horiguchi > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes --531381512-1088296400-1400727068=:13243-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org