From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbaFEUzd (ORCPT ); Thu, 5 Jun 2014 16:55:33 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:63745 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbaFEUzb (ORCPT ); Thu, 5 Jun 2014 16:55:31 -0400 Date: Thu, 5 Jun 2014 13:55:28 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Oleg Drokin cc: Andrew Morton , Rik van Riel , Mel Gorman , Cody P Schafer , Randy Dunlap , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [patch v2] mm, pcp: allow restoring percpu_pagelist_fraction default In-Reply-To: Message-ID: References: <1399166883-514-1-git-send-email-green@linuxhacker.ru> <2C763027-307F-4BC0-8C0A-7E3D5957A4DA@linuxhacker.ru> <85AFB547-D3A1-4818-AD82-FF90909775D2@linuxhacker.ru> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Jun 2014, Oleg Drokin wrote: > Minor nitpick I guess, but ret cannot be anything but 0 here I think (until somebody changes the way proc_dointvec_minmax for write=true operates)? > We need to return 0 regardless of whether proc_dointvec_minmax() changes in the future, the patch is correct. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com [209.85.213.176]) by kanga.kvack.org (Postfix) with ESMTP id 8D15F6B0037 for ; Thu, 5 Jun 2014 16:55:32 -0400 (EDT) Received: by mail-ig0-f176.google.com with SMTP id a13so3727306igq.15 for ; Thu, 05 Jun 2014 13:55:32 -0700 (PDT) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [2607:f8b0:4001:c03::235]) by mx.google.com with ESMTPS id t20si18867245igr.23.2014.06.05.13.55.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Jun 2014 13:55:31 -0700 (PDT) Received: by mail-ie0-f181.google.com with SMTP id rp18so1363893iec.26 for ; Thu, 05 Jun 2014 13:55:31 -0700 (PDT) Date: Thu, 5 Jun 2014 13:55:28 -0700 (PDT) From: David Rientjes Subject: Re: [patch v2] mm, pcp: allow restoring percpu_pagelist_fraction default In-Reply-To: Message-ID: References: <1399166883-514-1-git-send-email-green@linuxhacker.ru> <2C763027-307F-4BC0-8C0A-7E3D5957A4DA@linuxhacker.ru> <85AFB547-D3A1-4818-AD82-FF90909775D2@linuxhacker.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Oleg Drokin Cc: Andrew Morton , Rik van Riel , Mel Gorman , Cody P Schafer , Randy Dunlap , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org On Wed, 4 Jun 2014, Oleg Drokin wrote: > Minor nitpick I guess, but ret cannot be anything but 0 here I think (until somebody changes the way proc_dointvec_minmax for write=true operates)? > We need to return 0 regardless of whether proc_dointvec_minmax() changes in the future, the patch is correct. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org