From: Kirill Batuzov <batuzovk@ispras.ru>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH qom v2 2/4] hw: Fix qemu_allocate_irqs() leaks
Date: Wed, 18 Jun 2014 18:03:29 +0400 (MSK) [thread overview]
Message-ID: <alpine.DEB.2.02.1406181754100.4254@bulbul.intra.ispras.ru> (raw)
In-Reply-To: <43e8afd2e93f46da84a942e6adf3dac19b115b9a.1403061437.git.peter.crosthwaite@xilinx.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1441 bytes --]
On Wed, 18 Jun 2014, Peter Crosthwaite wrote:
> From: Andreas Färber <afaerber@suse.de>
>
> Replace qemu_allocate_irqs(foo, bar, 1)[0]
> with qemu_allocate_irq(foo, bar, 0).
>
> This avoids leaking the dereferenced qemu_irq *.
>
> Cc: Kirill Batuzov <batuzovk@ispras.ru>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> [PC Changes:
> * Applied change to instance in sh4/sh7750.c
> ]
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> Changed since 1:
> Applied change to instance in sh4/sh7750.c (Kirill review)
>
> hw/arm/omap1.c | 14 +++++++-------
> hw/arm/omap2.c | 2 +-
> hw/arm/pxa2xx.c | 4 ++--
> hw/arm/spitz.c | 4 ++--
> hw/arm/z2.c | 2 +-
> hw/core/irq.c | 4 ++--
> hw/dma/omap_dma.c | 4 ++--
> hw/ide/microdrive.c | 2 +-
> hw/misc/cbus.c | 6 +++---
> hw/pcmcia/pxa2xx.c | 2 +-
> hw/sd/omap_mmc.c | 2 +-
> hw/sd/sdhci.c | 4 ++--
> hw/sh4/sh7750.c | 3 +--
> hw/timer/omap_gptimer.c | 4 ++--
> 14 files changed, 28 insertions(+), 29 deletions(-)
>
Reviewed-by: Kirill Batuzov <batuzovk@ispras.ru>
--
Kirill
next prev parent reply other threads:[~2014-06-18 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 7:53 [Qemu-devel] [PATCH qom v2 0/4] QOMify IRQs Peter Crosthwaite
2014-06-18 7:54 ` [Qemu-devel] [PATCH qom v2 1/4] sdhci: Fix misuse of qemu_free_irqs() Peter Crosthwaite
2014-06-27 9:39 ` Andreas Färber
2014-06-18 7:55 ` [Qemu-devel] [PATCH qom v2 2/4] hw: Fix qemu_allocate_irqs() leaks Peter Crosthwaite
2014-06-18 14:03 ` Kirill Batuzov [this message]
2014-06-27 9:45 ` Andreas Färber
2014-06-27 10:21 ` Peter Crosthwaite
2014-06-18 7:56 ` [Qemu-devel] [PATCH qom v2 3/4] irq: Allocate IRQs individually Peter Crosthwaite
2014-06-18 7:57 ` [Qemu-devel] [PATCH qom v2 4/4] irq: Slim conversion of qemu_irq to QOM Peter Crosthwaite
2014-06-18 14:40 ` Paolo Bonzini
2014-06-19 4:57 ` Peter Crosthwaite
2014-06-19 5:47 ` Paolo Bonzini
2014-06-25 9:39 ` [Qemu-devel] [PATCH qom v2 0/4] QOMify IRQs Peter Crosthwaite
2014-06-27 9:53 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406181754100.4254@bulbul.intra.ispras.ru \
--to=batuzovk@ispras.ru \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.