From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v7a 14/14] xen/arm: Restrict saving of gic register for idle domain Date: Fri, 4 Jul 2014 15:25:27 +0100 Message-ID: References: <1404196882-23473-1-git-send-email-vijay.kilari@gmail.com> <1404196882-23473-15-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404196882-23473-15-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 1 Jul 2014, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Check for idle domain is missing before saving gic context. > Xen stays in hypervisor mode when idle vcpu is running. > So no need to save and restore context when switched to/from > idle domain > > Signed-off-by: Vijaya Kumar K Acked-by: Stefano Stabellini > xen/arch/arm/gic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index e1e27b35..c0d70b8 100644 > --- a/xen/arch/arm/gic.c > +++ b/xen/arch/arm/gic.c > @@ -70,6 +70,9 @@ void gic_save_state(struct vcpu *v) > { > ASSERT(!local_irq_is_enabled()); > > + if ( is_idle_vcpu(v) ) > + return; > + > /* No need for spinlocks here because interrupts are disabled around > * this call and it only accesses struct vcpu fields that cannot be > * accessed simultaneously by another pCPU. > -- > 1.7.9.5 >