Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Wed, 23 Jul 2014, Roger Pau Monné wrote:
> On 22/07/14 14:26, Stefano Stabellini wrote:
> > On Tue, 22 Jul 2014, Roger Pau Monné wrote:
> >> On 27/05/14 15:29, Stefan Hajnoczi wrote:
> >>> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
> >>>> The current behaviour of tap_open for BSD systems differ greatly from
> >>>> it's Linux counterpart. Since FreeBSD supports interface renaming and
> >>>> tap device cloning by opening /dev/tap, implement a FreeBSD specific
> >>>> version of tap_open that behaves like it's Linux counterpart.
> >>>>
> >>>> This is specially important for toolstacks that use Qemu (like Xen
> >>>> libxl), in order to have a unified behaviour across suported
> >>>> platforms.
> >>>>
> >>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>> Cc: xen-devel@lists.xenproject.org
> >>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>>> Cc: Anthony Liguori <aliguori@us.ibm.com>
> >>>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> >>>> ---
> >>>>  net/tap-bsd.c |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >>>>  1 files changed, 69 insertions(+), 1 deletions(-)
> >>>
> >>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >>
> >> I still don't see this committed to the repository, should I ping someone?
> > 
> > I was assuming that this patch would go via some other tree.  But if
> > Stefan is OK I could pick it up and submit a pull request for both patch
> > 1 and 2 of this series.
> 
> Would you do the backport of those three patches (one is already
> committed as e02bc6) to the qemu-xen repo at the same time, or would you
> like me to remind you about this in a month or so?
> 
> I would really like to have all this patches in Xen 4.5 if possible.

I should remember when I'll send a pull request (when 2.1 will be
out). But please remind me if I'll forget.