From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755963AbaHESRc (ORCPT ); Tue, 5 Aug 2014 14:17:32 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:42339 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755475AbaHESQG (ORCPT ); Tue, 5 Aug 2014 14:16:06 -0400 X-IronPort-AV: E=Sophos;i="5.01,806,1400018400"; d="scan'208";a="88390351" Date: Tue, 5 Aug 2014 20:16:04 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Michal Marek cc: Himangi Saraogi , Gilles Muller , Nicolas Palix , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON In-Reply-To: <53E0E9D0.9040500@suse.cz> Message-ID: References: <20140720213635.GA12365@himangi-Dell> <53E0E9D0.9040500@suse.cz> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Aug 2014, Michal Marek wrote: > On 2014-07-20 23:36, Himangi Saraogi wrote: > > This script detects cases where BUG() follows an if condition on an > > expression and replaces the if condition and BUG() with a BUG_ON having > > the conditional expression of the if statement as argument. > > > > Signed-off-by: Himangi Saraogi > > Acked-by: Julia Lawall > > Is this a result of some internal review, or where does Julia's Acked-by > come from? I'm just wondering, because I haven't seen any previous > version of this patch. She sent it to me first. It's OK with me. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Tue, 5 Aug 2014 20:16:04 +0200 (CEST) Subject: [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON In-Reply-To: <53E0E9D0.9040500@suse.cz> References: <20140720213635.GA12365@himangi-Dell> <53E0E9D0.9040500@suse.cz> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Tue, 5 Aug 2014, Michal Marek wrote: > On 2014-07-20 23:36, Himangi Saraogi wrote: > > This script detects cases where BUG() follows an if condition on an > > expression and replaces the if condition and BUG() with a BUG_ON having > > the conditional expression of the if statement as argument. > > > > Signed-off-by: Himangi Saraogi > > Acked-by: Julia Lawall > > Is this a result of some internal review, or where does Julia's Acked-by > come from? I'm just wondering, because I haven't seen any previous > version of this patch. She sent it to me first. It's OK with me. julia