From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbaHXSk4 (ORCPT ); Sun, 24 Aug 2014 14:40:56 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:55880 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbaHXSky (ORCPT ); Sun, 24 Aug 2014 14:40:54 -0400 X-IronPort-AV: E=Sophos;i="5.04,391,1406584800"; d="scan'208";a="91142230" Date: Sun, 24 Aug 2014 20:40:50 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Geert Uytterhoeven cc: Julia Lawall , Thomas Winischhofer , Joe Perches , "kernel-janitors@vger.kernel.org" , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment In-Reply-To: Message-ID: References: <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr> <1408818808-18850-7-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Aug 2014, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall wrote: > > --- > > The patches in this series do not depend on each other. > > > > This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Do you want me to resend this patch with the new subject, or just keep it in mind for the future? thanks, julia > > > drivers/video/fbdev/sis/init301.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > > index a89e3ca..295e0de 100644 > > --- a/drivers/video/fbdev/sis/init301.c > > +++ b/drivers/video/fbdev/sis/init301.c > > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > > } else { > > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sun, 24 Aug 2014 18:40:50 +0000 Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment Message-Id: List-Id: References: <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr> <1408818808-18850-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Julia Lawall , Thomas Winischhofer , Joe Perches , "kernel-janitors@vger.kernel.org" , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Linux Fbdev development list , "linux-kernel@vger.kernel.org" On Sun, 24 Aug 2014, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall wrote: > > --- > > The patches in this series do not depend on each other. > > > > This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Do you want me to resend this patch with the new subject, or just keep it in mind for the future? thanks, julia > > > drivers/video/fbdev/sis/init301.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > > index a89e3ca..295e0de 100644 > > --- a/drivers/video/fbdev/sis/init301.c > > +++ b/drivers/video/fbdev/sis/init301.c > > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > > } else { > > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >