From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 4/4] amd/seattle: Initial revision of AMD Seattle support Date: Thu, 2 Oct 2014 10:10:10 +0100 Message-ID: References: <1412150877-4090-1-git-send-email-suravee.suthikulpanit@amd.com> <1412150877-4090-5-git-send-email-suravee.suthikulpanit@amd.com> <542C5453.7040004@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <542C5453.7040004@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suravee Suthikulanit Cc: "julien.grall@linaro.org" , "xen-devel@lists.xen.org" , "ian.campbell@citrix.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 1 Oct 2014, Suravee Suthikulanit wrote: > On 10/1/2014 5:10 AM, Stefano Stabellini wrote: > > On Wed, 1 Oct 2014, suravee.suthikulpanit@amd.com wrote: > > > From: Suravee Suthikulpanit > > > > > > This patch add inital (minimal) platform support for AMD Seattle, > > > which mainly just define the matching ID, and specify system_off, > > > and sytem_reset mechanism. > > > > > > Initially, the firmware only support a subset of PSCI-0.2 functions, > > > system-off and sytem-reset. The boot protocol is still using spin-table. > > > > In that case, aren't you missing > > > > cpu_up = cpu_up_send_sgi > > > > ? > > > > Or are you just going to assume that the firmware is going to be updated > > to support full PSCI 0.2? > > I thought the platform_cpu_up() is only called from the > arch/arm/arm32/smpboot.c. Is it also used for ARM64? You are right, on arm64 we just look at enable-method > And yes, the firmware will support full PSCI-0.2 eventually. > > Thanks, > > Suravee > >