Re: [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page

From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Frediano Ziglio <frediano.ziglio@huawei.com>
Cc: xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page
Date: Thu, 6 Nov 2014 17:30:59 +0000	[thread overview]
Message-ID: <alpine.DEB.2.02.1411061730240.22875__47872.7773217999$1415295711$gmane$org@kaball.uk.xensource.com> (raw)
In-Reply-To: <1415293651-13917-1-git-send-email-frediano.ziglio@huawei.com>

On Thu, 6 Nov 2014, Frediano Ziglio wrote:
> On ARM error code is not 0 so avoid to return it as error.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Could you please fix the same error in lib/swiotlb.c too please?

>  drivers/xen/swiotlb-xen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index ebd8f21..3b8d628 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -425,7 +425,7 @@ dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
>  	 */
>  	if (!dma_capable(dev, dev_addr, size)) {
>  		swiotlb_tbl_unmap_single(dev, map, size, dir);
> -		dev_addr = 0;
> +		dev_addr = DMA_ERROR_CODE;
>  	}
>  	return dev_addr;
>  }
> -- 
> 1.9.1
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://secure-web.cisco.com/1cvjROyUxV6SnA0uBTMRubqrQWsaXGhps-FWjY3vly9AxaKKlt2DPY7GjL0FCHeP4rsbjKsc-P4zH2_7-kpcxwEH-udGrGCCqkCLlH1-fLOo1X6Nlui6EwEVHUpB2r7gt-Gsgxbep9QWPnIdypDPNf8Hf5clxCMXYcvWsOK5s3qg/http%3A%2F%2Fwww.tux.org%2Flkml%2F
> 