From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751515AbaKWPv5 (ORCPT ); Sun, 23 Nov 2014 10:51:57 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11808 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbaKWPv4 (ORCPT ); Sun, 23 Nov 2014 10:51:56 -0500 X-IronPort-AV: E=Sophos;i="5.07,443,1413237600"; d="scan'208";a="109099980" Date: Sun, 23 Nov 2014 16:51:53 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: Joe Perches , Andreas Noever , LKML , kernel-janitors@vger.kernel.org Subject: Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free" In-Reply-To: <54720061.7010401@users.sourceforge.net> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F16A5.8030405@users.sourceforge.net> <546F2E50.5040804@users.sourceforge.net> <1416593688.6651.39.camel@perches.com> <5471EBAC.40903@users.sourceforge.net> <1416756022.6651.45.camel@perches.com> <54720061.7010401@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Nov 2014, SF Markus Elfring wrote: > >> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268 > > > > I think static functions can be named whatever > > the developer chooses. > > I agree also that this implementation detail is correct in principle. > > Is a renaming of such identifiers feasible so that the probability of > other name clashes can be reduced and corresponding static source > code analysis might become a bit easier? Why not just make the static source code analysis aware of the problem? You can treat static functions differently that non-static ones. There is no need to change the code. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sun, 23 Nov 2014 15:51:53 +0000 Subject: Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free" Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F16A5.8030405@users.sourceforge.net> <546F2E50.5040804@users.sourceforge.net> <1416593688.6651.39.camel@perches.com> <5471EBAC.40903@users.sourceforge.net> <1416756022.6651.45.camel@perches.com> <54720061.7010401@users.sourceforge.net> In-Reply-To: <54720061.7010401@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: Joe Perches , Andreas Noever , LKML , kernel-janitors@vger.kernel.org On Sun, 23 Nov 2014, SF Markus Elfring wrote: > >> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/t= ree/drivers/char/tpm/xen-tpmfront.c?id=FC14f9c1272f62c3e8d01300f52467c0d9af= 50f9#n268 > >=20 > > I think static functions can be named whatever > > the developer chooses. >=20 > I agree also that this implementation detail is correct in principle. >=20 > Is a renaming of such identifiers feasible so that the probability of > other name clashes can be reduced and corresponding static source > code analysis might become a bit easier? Why not just make the static source code analysis aware of the problem? =20 You can treat static functions differently that non-static ones. There is = no need to change the code. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html