From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:32716 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbaLHGnX (ORCPT ); Mon, 8 Dec 2014 01:43:23 -0500 Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) From: Julia Lawall To: Julian Calaby cc: Julia Lawall , linux-wireless , kernel-janitors@vger.kernel.org, linux@rasmusvillemoes.dk, Joe Perches , "devel@driverdev.osuosl.org" , linux-scsi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-samsung-soc@vger.kernel.org, "Mailing List, Arm" , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, netdev , linux-usb@vger.kernel.org Subject: Re: [PATCH 0/20] fix misspelling of current function in string In-Reply-To: Message-ID: (sfid-20141208_074334_228328_3E04BFE7) References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 8 Dec 2014, Julian Calaby wrote: > Hi Julia, > > On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > > These patches replace what appears to be a reference to the name of the > > current function but is misspelled in some way by either the name of the > > function itself, or by %s and then __func__ in an argument list. > > Would there be any value in doing this for _all_ cases where the > function name is written in a format string? Probably. But there are a lot of them. Even for the misspellings, I have only don about 1/3 of the cases. On the other hand, the misspelling have to be checked carefully, because a misspelling of one thing could be the correct spelling of the thing thst was actually intended. Joe, however, points out that a lot of these prints are just for function tracing, and could be removed. I worked on another semantic patch that tries to do that. It might be better to remove those prints completely, rather than sending one patch to transform them and then one patch to remove them after that. That is why for this series I did only the ones where there was actually a problem. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH 0/20] fix misspelling of current function in string Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) Message-ID: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "devel@driverdev.osuosl.org" , linux-samsung-soc@vger.kernel.org, linux-scsi , linux@rasmusvillemoes.dk, linux-wireless , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, Julia Lawall , netdev , linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org, Joe Perches , "Mailing List, Arm" To: Julian Calaby Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" List-Id: netdev.vger.kernel.org T24gTW9uLCA4IERlYyAyMDE0LCBKdWxpYW4gQ2FsYWJ5IHdyb3RlOgoKPiBIaSBKdWxpYSwKPiAK PiBPbiBNb24sIERlYyA4LCAyMDE0IGF0IDY6MjAgQU0sIEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3 YWxsQGxpcDYuZnI+IHdyb3RlOgo+ID4gVGhlc2UgcGF0Y2hlcyByZXBsYWNlIHdoYXQgYXBwZWFy cyB0byBiZSBhIHJlZmVyZW5jZSB0byB0aGUgbmFtZSBvZiB0aGUKPiA+IGN1cnJlbnQgZnVuY3Rp b24gYnV0IGlzIG1pc3NwZWxsZWQgaW4gc29tZSB3YXkgYnkgZWl0aGVyIHRoZSBuYW1lIG9mIHRo ZQo+ID4gZnVuY3Rpb24gaXRzZWxmLCBvciBieSAlcyBhbmQgdGhlbiBfX2Z1bmNfXyBpbiBhbiBh cmd1bWVudCBsaXN0Lgo+IAo+IFdvdWxkIHRoZXJlIGJlIGFueSB2YWx1ZSBpbiBkb2luZyB0aGlz IGZvciBfYWxsXyBjYXNlcyB3aGVyZSB0aGUKPiBmdW5jdGlvbiBuYW1lIGlzIHdyaXR0ZW4gaW4g YSBmb3JtYXQgc3RyaW5nPwoKUHJvYmFibHkuICBCdXQgdGhlcmUgYXJlIGEgbG90IG9mIHRoZW0u ICBFdmVuIGZvciB0aGUgbWlzc3BlbGxpbmdzLCBJIGhhdmUgCm9ubHkgZG9uIGFib3V0IDEvMyBv ZiB0aGUgY2FzZXMuCgpPbiB0aGUgb3RoZXIgaGFuZCwgdGhlIG1pc3NwZWxsaW5nIGhhdmUgdG8g YmUgY2hlY2tlZCBjYXJlZnVsbHksIGJlY2F1c2UgYSAKbWlzc3BlbGxpbmcgb2Ygb25lIHRoaW5n IGNvdWxkIGJlIHRoZSBjb3JyZWN0IHNwZWxsaW5nIG9mIHRoZSB0aGluZyB0aHN0IAp3YXMgYWN0 dWFsbHkgaW50ZW5kZWQuCgpKb2UsIGhvd2V2ZXIsIHBvaW50cyBvdXQgdGhhdCBhIGxvdCBvZiB0 aGVzZSBwcmludHMgYXJlIGp1c3QgZm9yIGZ1bmN0aW9uIAp0cmFjaW5nLCBhbmQgY291bGQgYmUg cmVtb3ZlZC4gIEkgd29ya2VkIG9uIGFub3RoZXIgc2VtYW50aWMgcGF0Y2ggdGhhdCAKdHJpZXMg dG8gZG8gdGhhdC4gIEl0IG1pZ2h0IGJlIGJldHRlciB0byByZW1vdmUgdGhvc2UgcHJpbnRzIGNv bXBsZXRlbHksIApyYXRoZXIgdGhhbiBzZW5kaW5nIG9uZSBwYXRjaCB0byB0cmFuc2Zvcm0gdGhl bSBhbmQgdGhlbiBvbmUgcGF0Y2ggdG8gCnJlbW92ZSB0aGVtIGFmdGVyIHRoYXQuICBUaGF0IGlz IHdoeSBmb3IgdGhpcyBzZXJpZXMgSSBkaWQgb25seSB0aGUgb25lcyAKd2hlcmUgdGhlcmUgd2Fz IGFjdHVhbGx5IGEgcHJvYmxlbS4KCmp1bGlhCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 08 Dec 2014 06:43:16 +0000 Subject: Re: [PATCH 0/20] fix misspelling of current function in string Message-Id: List-Id: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Calaby Cc: "devel@driverdev.osuosl.org" , linux-samsung-soc@vger.kernel.org, linux-scsi , linux@rasmusvillemoes.dk, linux-wireless , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, Julia Lawall , netdev , linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org, Joe Perches , "Mailing List, Arm" On Mon, 8 Dec 2014, Julian Calaby wrote: > Hi Julia, > > On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > > These patches replace what appears to be a reference to the name of the > > current function but is misspelled in some way by either the name of the > > function itself, or by %s and then __func__ in an argument list. > > Would there be any value in doing this for _all_ cases where the > function name is written in a format string? Probably. But there are a lot of them. Even for the misspellings, I have only don about 1/3 of the cases. On the other hand, the misspelling have to be checked carefully, because a misspelling of one thing could be the correct spelling of the thing thst was actually intended. Joe, however, points out that a lot of these prints are just for function tracing, and could be removed. I worked on another semantic patch that tries to do that. It might be better to remove those prints completely, rather than sending one patch to transform them and then one patch to remove them after that. That is why for this series I did only the ones where there was actually a problem. julia From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) From: Julia Lawall To: Julian Calaby Subject: Re: [PATCH 0/20] fix misspelling of current function in string In-Reply-To: Message-ID: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "devel@driverdev.osuosl.org" , linux-samsung-soc@vger.kernel.org, linux-scsi , linux@rasmusvillemoes.dk, linux-wireless , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, Julia Lawall , netdev , linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org, Joe Perches , "Mailing List, Arm" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 8 Dec 2014, Julian Calaby wrote: > Hi Julia, > > On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > > These patches replace what appears to be a reference to the name of the > > current function but is misspelled in some way by either the name of the > > function itself, or by %s and then __func__ in an argument list. > > Would there be any value in doing this for _all_ cases where the > function name is written in a format string? Probably. But there are a lot of them. Even for the misspellings, I have only don about 1/3 of the cases. On the other hand, the misspelling have to be checked carefully, because a misspelling of one thing could be the correct spelling of the thing thst was actually intended. Joe, however, points out that a lot of these prints are just for function tracing, and could be removed. I worked on another semantic patch that tries to do that. It might be better to remove those prints completely, rather than sending one patch to transform them and then one patch to remove them after that. That is why for this series I did only the ones where there was actually a problem. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) Subject: [PATCH 0/20] fix misspelling of current function in string In-Reply-To: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 8 Dec 2014, Julian Calaby wrote: > Hi Julia, > > On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > > These patches replace what appears to be a reference to the name of the > > current function but is misspelled in some way by either the name of the > > function itself, or by %s and then __func__ in an argument list. > > Would there be any value in doing this for _all_ cases where the > function name is written in a format string? Probably. But there are a lot of them. Even for the misspellings, I have only don about 1/3 of the cases. On the other hand, the misspelling have to be checked carefully, because a misspelling of one thing could be the correct spelling of the thing thst was actually intended. Joe, however, points out that a lot of these prints are just for function tracing, and could be removed. I worked on another semantic patch that tries to do that. It might be better to remove those prints completely, rather than sending one patch to transform them and then one patch to remove them after that. That is why for this series I did only the ones where there was actually a problem. julia