From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [RFC 4/7] libxl: Add "stubdomain_version" to
 domain_build_info.
Date: Fri, 6 Feb 2015 17:54:12 +0000
Message-ID: <alpine.DEB.2.02.1502061753370.29696@kaball.uk.xensource.com>
References: <1423022775-7132-1-git-send-email-eshelton@pobox.com>
	<1423022775-7132-5-git-send-email-eshelton@pobox.com>
	<alpine.DEB.2.02.1502061603590.29696@kaball.uk.xensource.com>
	<CAPQw5rkx67Nyc0fLoUVA5xN=GBDjJnDEiOGBggTQ+Y1c-4Ghog@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAPQw5rkx67Nyc0fLoUVA5xN=GBDjJnDEiOGBggTQ+Y1c-4Ghog@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Eric Shelton <eshelton@pobox.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 6 Feb 2015, Eric Shelton wrote:
> On Fri, Feb 6, 2015 at 11:06 AM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Tue, 3 Feb 2015, Eric Shelton wrote:
> >> This enum gives the ability to select between a MiniOS-based QEMU
> >> traditional stub domain and a Linux-based QEMU upstream stub domain.  To
> >> use the Linux-based stubdomain, the following two lines should be
> >> included in the appropriate xl.cfg file:
> >>
> >> device_model_version="qemu-xen"
> >> device_model_stubdomain_override=1
> >>
> >> To use the MiniOS-based stubdomain, the following is used instead:
> >>
> >> device_model_version="qemu-xen-traditional"
> >> device_model_stubdomain_override=1
> 
> ...
> 
> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> >> index 02be466..8d0ac3b 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -83,6 +83,12 @@ libxl_device_model_version = Enumeration("device_model_version", [
> >>      (2, "QEMU_XEN"),             # Upstream based qemu-xen device model
> >>      ])
> >>
> >> +# Give the kernel running in the stub-domain
> >> +libxl_stubdomain_version = Enumeration("stubdomain_version", [
> >
> > This should just be called stubdomain_version.
> 
> I'm sorry - I don't quite catch what you are suggesting.  Are you
> saying that the VM config file should have a line like this?
> 
> stubdomain_version="linux"

Sorry I misread your patch. Ignore my previous comment.