Re: [Outreachy kernel] [PATCH 08/10] Staging: rtl8712: Fix incorrect assignment type in rtl8712_xmit.c

[Julia Lawall <julia.lawall@lip6.fr>]

On Sun, 22 Mar 2015, Vatika Harlalka wrote:

> This patch is to fix Sparse warnings due to incorrect assignment
> type in rtl8712_xmit.c

You should explain why the change is correct, not just make the message go 
away.

julia

> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl8712_xmit.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 732e774..c0c86ef 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -550,22 +550,22 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>  			 * This will maybe make the handshake smooth.
>  			 */
>  			/*driver uses data rate*/
> -			ptxdesc->txdw4 = cpu_to_le32(0x80000000);
> -			ptxdesc->txdw5 = cpu_to_le32(0x001f8000);/*1M*/
> +			ptxdesc->txdw4 = 0x80000000;
> +			ptxdesc->txdw5 = 0x001f8000;/*1M*/
>  		}
>  		if (pattrib->pctrl == 1) { /* mp tx packets */
>  			struct tx_desc *ptxdesc_mp;
>  
>  			ptxdesc_mp = &txdesc_mp;
>  			/* offset 8 */
> -			ptxdesc->txdw2 = cpu_to_le32(ptxdesc_mp->txdw2);
> +			ptxdesc->txdw2 = ptxdesc_mp->txdw2;
>  			if (bmcst)
>  				ptxdesc->txdw2 |= BMC;
>  			ptxdesc->txdw2 |= BK;
>  			/* offset 16 */
> -			ptxdesc->txdw4 = cpu_to_le32(ptxdesc_mp->txdw4);
> +			ptxdesc->txdw4 = ptxdesc_mp->txdw4;
>  			/* offset 20 */
> -			ptxdesc->txdw5 = cpu_to_le32(ptxdesc_mp->txdw5);
> +			ptxdesc->txdw5 = ptxdesc_mp->txdw5;
>  			pattrib->pctrl = 0;/* reset to zero; */
>  		}
>  	} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
> @@ -585,12 +585,12 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>  		 * correct mapping between AC&Endpoint,
>  		 * the purpose is that correct mapping let the MAC releases
>  		 * the AC Queue list correctly. */
> -		ptxdesc->txdw3 = cpu_to_le32((pattrib->priority << SEQ_SHT) &
> -					      0x0fff0000);
> +		ptxdesc->txdw3 = (pattrib->priority << SEQ_SHT) &
> +					      0x0fff0000;
>  		/* offset 16 */
> -		ptxdesc->txdw4 = cpu_to_le32(0x80002040);/*gtest*/
> +		ptxdesc->txdw4 = 0x80002040;/*gtest*/
>  		/* offset 20 */
> -		ptxdesc->txdw5 = cpu_to_le32(0x001f8000);/* gtest 1M */
> +		ptxdesc->txdw5 = 0x001f8000;/* gtest 1M */
>  	} else if (pxmitframe->frame_tag == TXAGG_FRAMETAG) {
>  		/* offset 4 */
>  		qsel = 0x13;
> @@ -601,12 +601,12 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>  		ptxdesc->txdw1 |= (qsel << QSEL_SHT) & 0x00001f00;
>  		/*offset 8*/
>  		/*offset 12*/
> -		ptxdesc->txdw3 = cpu_to_le32((pattrib->seqnum << SEQ_SHT) &
> -					      0x0fff0000);
> +		ptxdesc->txdw3 = (pattrib->seqnum << SEQ_SHT) &
> +					      0x0fff0000;
>  		/*offset 16*/
> -		ptxdesc->txdw4 = cpu_to_le32(0x80002040);/*gtest*/
> +		ptxdesc->txdw4 = 0x80002040;/*gtest*/
>  		/*offset 20*/
> -		ptxdesc->txdw5 = cpu_to_le32(0x001f9600);/*gtest*/
> +		ptxdesc->txdw5 = 0x001f9600;/*gtest*/
>  	}
>  }
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/68911b4fb09acb91c39291e2596ce73cc3e8e2f2.1426983594.git.vatikaharlalka%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>