From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 1/8] raisin: Fix non-verbose case Date: Mon, 20 Apr 2015 18:07:57 +0100 Message-ID: References: <1429201182-1044-1-git-send-email-george.dunlap@eu.citrix.com> <5534BDB0.7040800@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: George Dunlap , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 20 Apr 2015, Stefano Stabellini wrote: > On Mon, 20 Apr 2015, George Dunlap wrote: > > On 04/17/2015 11:06 AM, Stefano Stabellini wrote: > > > On Thu, 16 Apr 2015, George Dunlap wrote: > > >> Because we use "set -e", we can't use the "a && b" construct, as it will fail and stop the script. > > >> > > >> Signed-off-by: George Dunlap > > > > > > I am wondering whether we should ban both a && b and a || b from the > > > code and just go with the more verbose but also harder to get wrong: > > > > > > if [[ $VERBOSE -eq 1 ]] > > > then > > > echo calling "$component"_"$1" > > > fi > > > > > > Reading the code and seeing a || b will tempt you into writing a && b. > > > > That's a good point. :-) Do you want to go it or shall I resend? > > Given that you have a couple of other patches to resend, you might as > well resend this one too. I made the change and committed it.