Re: [PATCH v4 13/17] xen/arm: ITS: Initialize physical ITS

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Fri, 10 Jul 2015, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> Initialize physical ITS driver from GIC v3 driver
> if LPIs are supported by hardware
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
>  xen/arch/arm/gic-v3.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 53554e6..f4881d7 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -694,6 +694,10 @@ static int __cpuinit gicv3_cpu_init(void)
>      if ( gicv3_enable_redist() )
>          return -ENODEV;
>  
> +        /* Give LPIs a spin */
> +    if ( gicv3_info.lpi_supported )
> +        its_cpu_init();

I see that actually is the other way around compared to what I
previously suggested. That is OK if we can count on the fact that if
lpis are supported by the gic, the presence of an its is guaranteed, but
I am not sure that is the case.

Otherwise we also need to check that an its is actually present.


>      /* Set priority on PPI and SGI interrupts */
>      priority = (GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | GIC_PRI_IPI << 8 |
>                  GIC_PRI_IPI);
> @@ -1312,6 +1316,9 @@ static int __init gicv3_init(void)
>      else
>          gicv3_info.lpi_supported = 0;
>  
> +    if ( gicv3_info.lpi_supported )
> +        its_init(&gicv3.rdist_data);
> +
>      gicv3_dist_init();
>      res = gicv3_cpu_init();
>      gicv3_hyp_init();
> -- 
> 1.7.9.5
>