All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: rtw_mlme_ext: Remove extra test expression
Date: Wed, 14 Oct 2015 07:51:38 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1510140749160.2038@localhost6.localdomain6> (raw)
In-Reply-To: <20151014002245.GA21441@ubuntu>

On Wed, 14 Oct 2015, Shivani Bhardwaj wrote:

> Logical and-ing of a struct and its member should be replaced by the
> member only.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index fca22ba..d28f29a 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1715,7 +1715,7 @@ OnAssocReq23a(struct rtw_adapter *padapter, struct recv_frame *precv_frame)
>  	spin_unlock_bh(&pstapriv->asoc_list_lock);
>  
>  	/*  now the station is qualified to join our BSS... */
> -	if (pstat && pstat->state & WIFI_FW_ASSOC_SUCCESS &&
> +	if (pstat->state & WIFI_FW_ASSOC_SUCCESS &&

I don't understand the reasoning here.  Are you sure that pstat is not 
NULL?  If you are the transformation is OK, but the commit message should 
be completely different.  If you are not sure that it is not NULL, then 
the code has to be in the original way.

Furthermore, note that pstat is not being &&d with pstat->state.  It is 
being &&d with pstat->state & WIFI_FW_ASSOC_SUCCESS.

julia

>  	    status == WLAN_STATUS_SUCCESS) {
>  		/* 1 bss_cap_update & sta_info_update23a */
>  		bss_cap_update_on_sta_join23a(padapter, pstat);
> -- 
> 2.1.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151014002245.GA21441%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
> 


  reply	other threads:[~2015-10-14  5:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  0:22 [PATCH] Staging: rtl8723au: rtw_mlme_ext: Remove extra test expression Shivani Bhardwaj
2015-10-14  5:51 ` Julia Lawall [this message]
2015-10-14  8:59   ` [Outreachy kernel] " Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1510140749160.2038@localhost6.localdomain6 \
    --to=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.