From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1032047AbbKFGoY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Nov 2015 01:44:24 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48037
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1031994AbbKFGoW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Nov 2015 01:44:22 -0500
X-IronPort-AV: E=Sophos;i="5.20,251,1444687200"; 
   d="scan'208";a="152858282"
Date: Fri, 6 Nov 2015 07:44:18 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: Julian Calaby <julian.calaby@gmail.com>
cc: Linus Torvalds <torvalds@linux-foundation.org>,
        David Miller <davem@davemloft.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        sparclinux <sparclinux@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Subject: Re: [GIT] Sparc
In-Reply-To: <CAGRGNgUFUTBA1HfaPpE7kkC3zSZ02S7dsLqVBTrDYbQ69FD80Q@mail.gmail.com>
Message-ID: <alpine.DEB.2.02.1511060743560.2054@localhost6.localdomain6>
References: <20151105.163959.1438115257720770769.davem@davemloft.net> <CA+55aFwvFvsZuiURSfKuP85tcQgNUwj+bXdL9smZgMV8c++1EQ@mail.gmail.com> <CA+55aFz54eqrSy0TM3JNLXzyHO-DjsTHBLTWY1HTeZSyMLf73A@mail.gmail.com>
 <CAGRGNgUFUTBA1HfaPpE7kkC3zSZ02S7dsLqVBTrDYbQ69FD80Q@mail.gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 6 Nov 2015, Julian Calaby wrote:

> Hi Linus,
> 
> On Fri, Nov 6, 2015 at 11:56 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Thu, Nov 5, 2015 at 4:43 PM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> >>
> >> Not that this *matters*, but it's a bit odd to have to cast constants
> >> to perfectly regular C types.
> >
> > Looking around with "git grep", there's a few more of these.
> >
> >  - btrfs seems to like "(unsigned long)-1"
> >
> >    There's a few other users of that too, including more sparc uses.
> >
> >  - scsi/qla seems to like "(unsigned long)<hexnumber>"
> >
> >  - fmdrv_common.h seems to like "((unsigned long)1<<x)" for bitmaps
> >
> > along with a smattering of random noise all over of "(unsigned long)
> > n" where 'n' is some integer.
> >
> > Apparently people aren't as aware of the normal "ul" postfix syntax as
> > I would have expected. That said, it's a hundred-odd cases in all of
> > the kernel, so it's still fairly rare.
> 
> Maybe this is something the kernel-janitors team should look at? (CC'd)

Do you have some concrete examples of the code that is undesirable?

thanks,
julia

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Fri, 06 Nov 2015 06:44:18 +0000
Subject: Re: [GIT] Sparc
Message-Id: <alpine.DEB.2.02.1511060743560.2054@localhost6.localdomain6>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20151105.163959.1438115257720770769.davem@davemloft.net> <CA+55aFwvFvsZuiURSfKuP85tcQgNUwj+bXdL9smZgMV8c++1EQ@mail.gmail.com> <CA+55aFz54eqrSy0TM3JNLXzyHO-DjsTHBLTWY1HTeZSyMLf73A@mail.gmail.com>
 <CAGRGNgUFUTBA1HfaPpE7kkC3zSZ02S7dsLqVBTrDYbQ69FD80Q@mail.gmail.com>
In-Reply-To: <CAGRGNgUFUTBA1HfaPpE7kkC3zSZ02S7dsLqVBTrDYbQ69FD80Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, David Miller <davem@davemloft.net>, Andrew Morton <akpm@linux-foundation.org>, sparclinux <sparclinux@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org

On Fri, 6 Nov 2015, Julian Calaby wrote:

> Hi Linus,
> 
> On Fri, Nov 6, 2015 at 11:56 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Thu, Nov 5, 2015 at 4:43 PM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> >>
> >> Not that this *matters*, but it's a bit odd to have to cast constants
> >> to perfectly regular C types.
> >
> > Looking around with "git grep", there's a few more of these.
> >
> >  - btrfs seems to like "(unsigned long)-1"
> >
> >    There's a few other users of that too, including more sparc uses.
> >
> >  - scsi/qla seems to like "(unsigned long)<hexnumber>"
> >
> >  - fmdrv_common.h seems to like "((unsigned long)1<<x)" for bitmaps
> >
> > along with a smattering of random noise all over of "(unsigned long)
> > n" where 'n' is some integer.
> >
> > Apparently people aren't as aware of the normal "ul" postfix syntax as
> > I would have expected. That said, it's a hundred-odd cases in all of
> > the kernel, so it's still fairly rare.
> 
> Maybe this is something the kernel-janitors team should look at? (CC'd)

Do you have some concrete examples of the code that is undesirable?

thanks,
julia