From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbbLTMvP (ORCPT ); Sun, 20 Dec 2015 07:51:15 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50626 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753833AbbLTMvO (ORCPT ); Sun, 20 Dec 2015 07:51:14 -0500 X-IronPort-AV: E=Sophos;i="5.20,454,1444687200"; d="scan'208";a="193186561" Date: Sun, 20 Dec 2015 13:51:11 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: LKML , kernel-janitors@vger.kernel.org, Richard Cochran Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable In-Reply-To: <5676A399.4080007@users.sourceforge.net> Message-ID: References: <56766488.9050402@users.sourceforge.net> <5676A399.4080007@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Dec 2015, SF Markus Elfring wrote: > >> Reuse the type from this poll call instead. > > > > Why use uint when the function return type it unsigned int? > > Do you prefer to express the type modifier once more there? I don't know what the sentence means, but I think that the type should be referenced in a consistent manner. > > On the other hand, why is the function return type unsigned int > > when there is a return of a negative constant? > > This implementation detail can trigger further software development > considerations, can't it? It would seem reasonable to address all of the signed/unsigned issues related to the function return value at once. julia > This is a general issue for the exception handling in several functions. > Would you like to improve any more source code around it? > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sun, 20 Dec 2015 12:51:11 +0000 Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable Message-Id: List-Id: References: <56766488.9050402@users.sourceforge.net> <5676A399.4080007@users.sourceforge.net> In-Reply-To: <5676A399.4080007@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Richard Cochran On Sun, 20 Dec 2015, SF Markus Elfring wrote: > >> Reuse the type from this poll call instead. > > > > Why use uint when the function return type it unsigned int? > > Do you prefer to express the type modifier once more there? I don't know what the sentence means, but I think that the type should be referenced in a consistent manner. > > On the other hand, why is the function return type unsigned int > > when there is a return of a negative constant? > > This implementation detail can trigger further software development > considerations, can't it? It would seem reasonable to address all of the signed/unsigned issues related to the function return value at once. julia > This is a general issue for the exception handling in several functions. > Would you like to improve any more source code around it? > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >