From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcACMsz (ORCPT ); Sun, 3 Jan 2016 07:48:55 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:36795 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbcACMsx (ORCPT ); Sun, 3 Jan 2016 07:48:53 -0500 X-IronPort-AV: E=Sophos;i="5.20,516,1444687200"; d="scan'208";a="195342316" Date: Sun, 3 Jan 2016 13:48:51 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() In-Reply-To: <5688E229.4010400@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 09:00:30 +0100 > > Pass the address of the data structure element "time" directly in calls > of the function "rtc_update_irq" instead of an extra initialisation > for one local variable at the beginning. Also, I don't see anything related to time in this patch. julia > > Signed-off-by: Markus Elfring > --- > drivers/rtc/rtc-ab-b5ze-s3.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c > index e3a015a..88f1d0b 100644 > --- a/drivers/rtc/rtc-ab-b5ze-s3.c > +++ b/drivers/rtc/rtc-ab-b5ze-s3.c > @@ -816,7 +816,6 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > struct i2c_client *client = data; > struct device *dev = &client->dev; > struct abb5zes3_rtc_data *rtc_data = dev_get_drvdata(dev); > - struct rtc_device *rtc = rtc_data->rtc; > u8 regs[ABB5ZES3_CTRL_SEC_LEN]; > int ret, handled = IRQ_NONE; > > @@ -844,8 +843,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check alarm flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_AF) { > dev_dbg(dev, "RTC alarm!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* Acknowledge and disable the alarm */ > _abb5zes3_rtc_clear_alarm(dev); > @@ -857,8 +855,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check watchdog Timer A flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_WTAF) { > dev_dbg(dev, "RTC timer!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* > * Acknowledge and disable the alarm. Note: WTAF > -- > 2.6.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr. [192.134.164.83]) by gmr-mx.google.com with ESMTPS id w129si843320wme.1.2016.01.03.04.48.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2016 04:48:52 -0800 (PST) Date: Sun, 3 Jan 2016 13:48:51 +0100 (CET) From: Julia Lawall To: SF Markus Elfring cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [rtc-linux] Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() In-Reply-To: <5688E229.4010400@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 09:00:30 +0100 > > Pass the address of the data structure element "time" directly in calls > of the function "rtc_update_irq" instead of an extra initialisation > for one local variable at the beginning. Also, I don't see anything related to time in this patch. julia > > Signed-off-by: Markus Elfring > --- > drivers/rtc/rtc-ab-b5ze-s3.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c > index e3a015a..88f1d0b 100644 > --- a/drivers/rtc/rtc-ab-b5ze-s3.c > +++ b/drivers/rtc/rtc-ab-b5ze-s3.c > @@ -816,7 +816,6 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > struct i2c_client *client = data; > struct device *dev = &client->dev; > struct abb5zes3_rtc_data *rtc_data = dev_get_drvdata(dev); > - struct rtc_device *rtc = rtc_data->rtc; > u8 regs[ABB5ZES3_CTRL_SEC_LEN]; > int ret, handled = IRQ_NONE; > > @@ -844,8 +843,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check alarm flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_AF) { > dev_dbg(dev, "RTC alarm!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* Acknowledge and disable the alarm */ > _abb5zes3_rtc_clear_alarm(dev); > @@ -857,8 +855,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check watchdog Timer A flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_WTAF) { > dev_dbg(dev, "RTC timer!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* > * Acknowledge and disable the alarm. Note: WTAF > -- > 2.6.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sun, 03 Jan 2016 12:48:51 +0000 Subject: Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() Message-Id: List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> In-Reply-To: <5688E229.4010400@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 09:00:30 +0100 > > Pass the address of the data structure element "time" directly in calls > of the function "rtc_update_irq" instead of an extra initialisation > for one local variable at the beginning. Also, I don't see anything related to time in this patch. julia > > Signed-off-by: Markus Elfring > --- > drivers/rtc/rtc-ab-b5ze-s3.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c > index e3a015a..88f1d0b 100644 > --- a/drivers/rtc/rtc-ab-b5ze-s3.c > +++ b/drivers/rtc/rtc-ab-b5ze-s3.c > @@ -816,7 +816,6 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > struct i2c_client *client = data; > struct device *dev = &client->dev; > struct abb5zes3_rtc_data *rtc_data = dev_get_drvdata(dev); > - struct rtc_device *rtc = rtc_data->rtc; > u8 regs[ABB5ZES3_CTRL_SEC_LEN]; > int ret, handled = IRQ_NONE; > > @@ -844,8 +843,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check alarm flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_AF) { > dev_dbg(dev, "RTC alarm!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* Acknowledge and disable the alarm */ > _abb5zes3_rtc_clear_alarm(dev); > @@ -857,8 +855,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check watchdog Timer A flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_WTAF) { > dev_dbg(dev, "RTC timer!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* > * Acknowledge and disable the alarm. Note: WTAF > -- > 2.6.3 > >