From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=815aa3427=Stefano.Stabellini@citrix.com>)
	id 1aK5Bl-0003vc-N1
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:17:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=815aa3427=Stefano.Stabellini@citrix.com>)
	id 1aK5Bg-0007Fb-OT
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:17:17 -0500
Received: from smtp.citrix.com ([66.165.176.89]:63964)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=815aa3427=Stefano.Stabellini@citrix.com>)
	id 1aK5Bg-0007FS-Jy
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:17:12 -0500
Date: Fri, 15 Jan 2016 14:16:40 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
In-Reply-To: <569822E1.7070304@redhat.com>
Message-ID: <alpine.DEB.2.02.1601151416110.16178@kaball.uk.xensource.com>
References: <1452689507-8188-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<alpine.DEB.2.02.1601141650290.16178@kaball.uk.xensource.com>
	<569822E1.7070304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Xen PCI passthru: Convert to
	realize()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Thu, 14 Jan 2016, Eric Blake wrote:
> On 01/14/2016 09:50 AM, Stefano Stabellini wrote:
> > Eric,
> > 
> > I'll wait for your reviewed-by on the whole series before committing.
> 
> Found a bug in 2/5, up to you if you want to fix that or wait for a v6.

If Cao is happy to update and resend, I'll wait for v6.


> > On Wed, 13 Jan 2016, Cao jin wrote:
> >> v5 changelog:
> >> 1. tweaked the commit message of patch 1/5 as sugguested.
> >> 2. xen_host_pci_sysfs_path() modification as sugguested.
> >> 3. remove local 'value' variable in xen_host_pci_get_value()
> 
> Basically, this change from v4 was not correct, after all.
> 
> >> 4. Indentation fix in patch 2/5.
> >> 5. Still use error_append_hint() because error_prepend() doesn`t exist.
> 
> But it does now: commit 8277d2aa.
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
>