From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v4 19/21] arm/acpi: Initialize serial port from ACPI SPCR table Date: Tue, 2 Feb 2016 17:51:14 +0000 Message-ID: References: <1453540813-15764-1-git-send-email-zhaoshenglong@huawei.com> <1453540813-15764-20-git-send-email-zhaoshenglong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453540813-15764-20-git-send-email-zhaoshenglong@huawei.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shannon Zhao Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, shannon.zhao@linaro.org List-Id: xen-devel@lists.xenproject.org On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Parse ACPI SPCR (Serial Port Console Redirection table) table and > initialize the serial port pl011. > > Signed-off-by: Parth Dixit > Signed-off-by: Shannon Zhao > --- > V4: Add other fields of SPCR Interface type Reviewed-by: Stefano Stabellini > xen/drivers/char/pl011.c | 37 +++++++++++++++++++++++++++++++++++++ > xen/include/acpi/actbl2.h | 9 +++++++++ > 2 files changed, 46 insertions(+) > > diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c > index 7e16294..9d47299 100644 > --- a/xen/drivers/char/pl011.c > +++ b/xen/drivers/char/pl011.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -308,6 +309,42 @@ DT_DEVICE_START(pl011, "PL011 UART", DEVICE_SERIAL) > .init = pl011_dt_uart_init, > DT_DEVICE_END > > +#ifdef CONFIG_ACPI > +static int __init pl011_acpi_uart_init(const void *data) > +{ > + acpi_status status; > + struct acpi_table_spcr *spcr = NULL; > + int res; > + > + status = acpi_get_table(ACPI_SIG_SPCR, 0, > + (struct acpi_table_header **)&spcr); > + > + if ( ACPI_FAILURE(status) ) > + { > + printk("pl011: Failed to get SPCR table\n"); > + return -EINVAL; > + } > + > + /* trigger/polarity information is not available in spcr */ > + irq_set_type(spcr->interrupt, IRQ_TYPE_EDGE_BOTH); > + > + res = pl011_uart_init(spcr->interrupt, spcr->serial_port.address, > + PAGE_SIZE); > + if ( res < 0 ) > + { > + printk("pl011: Unable to initialize\n"); > + return res; > + } > + > + return 0; > +} > + > +ACPI_DEVICE_START(apl011, "PL011 UART", DEVICE_SERIAL) > + .class_type = ACPI_SPCR_TYPE_PL011, > + .init = pl011_acpi_uart_init, > +ACPI_DEVICE_END > +#endif > + > /* > * Local variables: > * mode: C > diff --git a/xen/include/acpi/actbl2.h b/xen/include/acpi/actbl2.h > index 87bc6b3..d0508be 100644 > --- a/xen/include/acpi/actbl2.h > +++ b/xen/include/acpi/actbl2.h > @@ -815,6 +815,15 @@ struct acpi_table_spcr { > > #define ACPI_SPCR_DO_NOT_DISABLE (1) > > +/* SPCR Interface type */ > +#define ACPI_SPCR_TYPE_16550 0 > +#define ACPI_SPCR_TYPE_16550_SUB 0x1 > +#define ACPI_SPCR_TYPE_PL011 0x3 > +#define ACPI_SPCR_TYPE_SBSA_32 0xd > +#define ACPI_SPCR_TYPE_SBSA 0xe > +#define ACPI_SPCR_TYPE_DCC 0xf > +#define ACPI_SPCR_TYPE_BCM2835 0x10 > + > /******************************************************************************* > * > * SPMI - Server Platform Management Interface table > -- > 2.0.4 > >