From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755147AbcC3RSl (ORCPT ); Wed, 30 Mar 2016 13:18:41 -0400 Received: from mail-by2on0056.outbound.protection.outlook.com ([207.46.100.56]:43648 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752745AbcC3RSh (ORCPT ); Wed, 30 Mar 2016 13:18:37 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: opensource.altera.com; dkim=none (message not signed) header.d=none;opensource.altera.com; dmarc=none action=none header.from=opensource.altera.com; Date: Wed, 30 Mar 2016 12:11:14 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: CC: , , , , , , , , , , , , , , Subject: Re: [PATCH 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup In-Reply-To: <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> Message-ID: References: <1459351668-14622-1-git-send-email-tthayer@opensource.altera.com> <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR05CA061.namprd05.prod.outlook.com (10.141.250.51) To BLUPR03MB1361.namprd03.prod.outlook.com (10.163.80.27) X-MS-Office365-Filtering-Correlation-Id: 3133afdf-9394-4709-d241-08d358bf52f7 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1361;2:V21A6663Z57eMsK9SSY+5oud/c6ZlhPkDlVZgg1Rjp0HnpLVciwC9xy3I5nuZJcuMxhOrofj6cHm4oRQh1UmC3PMOr5wu2aNdMIWzyMuz39T52pmKhRPnggeMP1XaMryMNeo5ChJxDv6HXwYUB7UDK3eDSL1R4dhq3QWW8n0zm19gQ25TwyEKtvD5yS/6rGD;3:ZYf4Mm/SA+hgfZ7PSFL4Ma07AtaoWoUG+L2rFzIMbuFYeBuH3Dyt1YrdSURYlSDu6hSPyCV1JdoP68wbz5BaOXrJR3maH0z8yqSDojFdk8w3To1cm4kXqwzBIiym2pOU;25:+slwKAbeB/usd0kB0r8ZyFKJ97NAJaSFq3Rh5gbAWMRFFBt3K8hE5P7SuxrmGCIWiiShxWlOMIkWGN1zvTtu9LoFSDINR1H+ZOseje1u4A+fgYKvUI3Js0EsC/GXjPqTgxHldaEp/VpmtWuOL2yW1r871qn6og2t7Mq6s/9VzRuknM48DwHaBw8HBnxXLJVcBscT/27S7AL1AbYidUqH4SLocM8SShHKPmTIb/wvZAQe5hoz1Lmgjpp41NJdUvrkQuPVhrwZD+2zRweheG+H21dXpWBkZrbkPxKjmoNz3tdAzcxoTjZm+9p2JaUNLNLLswbneWr7jinAHKOabDz/srGr0wdUDVIpLXaakRsHpgE=;20:KuAma7hV57YjXnbIfUOb+/p2GehyQdDg0HX59xMRYRHFIspcJ41bslwMe3BahADHmc5LcFvrNXd5/IbndvWeLuNQTTAK94cLz/Xp0Ntz2qrKwNa2bLF+Cs+gsLzplEVV7rguw4kIFJbSOeenIlXj5hXSRtgPDJL0qOr8Gkioh58= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1361; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BLUPR03MB1361;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1361;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13024025)(5005006)(13015025)(13018025)(13023025)(13017025)(10201501046)(3002001);SRVR:CY1PR0301MB1291;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1291; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1361;4:eWvtMMLw4nf7roxT/Infh6Dxx84CHWzaVk6xEfH/2VdRNND36Njn6O5USZFfmtxXCR1cOXPUmR6+A+slm1eloTulNuDFk2XPS58HWr2VONxTXLj1MT7z4wy+m/u4tDltERGUtHYj1YV3YpD6yqwL6nVGUQP8HTPx6NBrKwJvLyS6RUtIwUcLEGleevnZG819QbS9MoPj+5P2iMHoupWQEfY7GZLXyxy9W4r8h9/4xN6Zkb7dfY8DAd1UrH4CGVvCpjA8gzOIXlZJ9mIs6OT78VbjJXVGt5kagAHYyq0ID6qwsvAGRnM6MKEOu/NGRpHYU5KGys0uk3e9KQfVnj7/rc1N2xkNB8VOsTa9WQo1EvuytVI6NH2+ejNzcIN6oxRn X-Forefront-PRVS: 08978A8F5C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(3846002)(42186005)(46406003)(83506001)(586003)(50466002)(86362001)(50986999)(76176999)(54356999)(66066001)(47776003)(1096002)(23726003)(6116002)(92566002)(5004730100002)(4001450100002)(2351001)(33716001)(189998001)(77096005)(4001350100001)(110136002)(2950100001)(19580405001)(5008740100001)(81166005)(53416004)(19580395003)(2906002)(4326007)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1361;H:linux-builds1.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1361;23:6UbE5uVYVs23XSdK92ya4eAYXWkfiz2xdAdb3ZV0M?= =?us-ascii?Q?uRXTfWk/u86JpRJxandmMCmhQSF6GeaP6C031L3J0fyZ96x9yJbsgq+AT2oZ?= =?us-ascii?Q?b6gO7DpnEQST04LgBHiaF2RhNNEcRonFiyEX0XIJw3LO/sWJXFKziTFwyDSd?= =?us-ascii?Q?AKKkbB9FwkXQM1Ks3XLwg76+saZwV9oEqQRya64dMCIN0dVvtQO2GQkblt2m?= =?us-ascii?Q?8EiFBBKlq8vw45FttB8YB49kuQIYfs5Ml9fddn2dAgUV+f129P/5d+Tjk8iG?= =?us-ascii?Q?GTciNBQ6lLnZjCOAUzt7IyIpkr1A20PPor/rv7JgzjmboaUKNelA9hXKRX7s?= =?us-ascii?Q?NYkALAqsN7kzys2x6ZfsEdy22TUn4SbYJ9WVF4wgjgYqFtBawr5oFXd7AHR2?= =?us-ascii?Q?b6ocP2Ey7QIBU9/RpcyCHBqXP02deXEmhVzhLrH9USuvQz1n0+q+VCd9PwOL?= =?us-ascii?Q?bAzi5Bw5TYiBanSRz+GLcyCzSMAAvmKdgMLyq+c7mYjxmIL/laLtI8y2ac6V?= =?us-ascii?Q?ClDIxVX2mPRWwR6XRWVoeI87KWo/w9INSCNYmZQZTewioTK7ZJc8UUzmBcaw?= =?us-ascii?Q?0bA31G56jX4IMFdOOnmSq769hDKGkhKjyMkzsK2rgJwYRMpMavF1bqYttatz?= =?us-ascii?Q?8euF36xYwA5Sd8djcPtK8yqeiIrdPzznw6f2DPza0z5Glv/kpao/n2FQlAS5?= =?us-ascii?Q?/vS9QvvCyiuGOtCiG9I1CtC0mVaLkp9pNRYsi6mba9G/z8Gl/q90Et6SHB1j?= =?us-ascii?Q?k0bKrj0QHrybxpYHeCkfFDrGWBM32M8wrpDpb5hY9J5v9GH4h4PyfdFwxV+K?= =?us-ascii?Q?lTTOPLZUcYBRaBHElCH/9qbu7Xdn0cDQFW1fKaMNAmopsqHp6DAhV1KwNigb?= =?us-ascii?Q?URoaG6KBe03VjMcf3/uaRV+bs8hrPCN0wLNyi1JKegf6mVBneAVWt0RtPjpn?= =?us-ascii?Q?n4tlxAzzI2MAp8ZKOu+soByupU+IKmOppRc+5eDVyJRxuhdLuEaq6E6zsUCh?= =?us-ascii?Q?oM=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1361;5:zXaClzIZMO72i6p9nbS/FpTzr+lUjMKCGAzgiI8B3dFpl4wBI8HtIaCv9e18GuLN1DtT1sUEFP0nXmE0311twLmAXVSPq1UWAvAwE2HDY6yjOw26YHMt18c6GbXOt4NveoH7DtKST9ox7H1C78wwSA==;24:ZO/PyjWd3gERsHaIN7V5bqalRgv9DQptuxyKhDwiSVHe6VAaBWbRMPqImPPyNWVQOZCkQbmWDT+dRjkr3jNArWk6ycIMzFBYlYzpleKfCwo=;20:c+rf46BIeP97VCX1+E6bWohZuvpgST8zhkqJy2cKOgW4TMB3iiEK6Oae8C2hS3NdTmFj/I3poR73RwniOMc0RbFj5NfsEV77EVHIxthLSZORkW+7FyL/HnCkgi6LbNuMSg7tt8dw52oSDsnZp+NjYBKmS/gpnrbHMup72NvdzFw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1361 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD001.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(339900001)(199003)(24454002)(189002)(50466002)(4326007)(23726003)(1096002)(16796002)(3720700001)(5008740100001)(53416004)(33716001)(2351001)(189998001)(54356999)(50986999)(92566002)(6806005)(2950100001)(76176999)(2906002)(1220700001)(6116002)(956001)(3846002)(4001350100001)(66066001)(85426001)(87936001)(105606002)(5004730100002)(19580405001)(77096005)(19580395003)(81166005)(110136002)(86362001)(83506001)(47776003)(586003)(4001450100002)(46406003)(106466001)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB1291;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD001;1:9ekgMn5M0Vvt+x9aQQjFx0kaw5bmG9eCmVaaMVVl3/n71swAoniOKCzsBLtBdgaylJ1mMsB1g2Ly2GYxuS0bQ4PLJHh3mbmDdJoKePYf8aNoR3Dd0pZmFgP3qK5bKgyenB1E/9HUPrTt0tIxufX4N7iPd7mX2HTsqeRKLoP91nx1V5dsDAmuzRj5rixlgVO07BJiYON+nbTa8ld0mUTSKyPhPE3PY9++oAA9LTtnM5Xmw+2yqBDnu8VUz8exfE2BOwDVtCO5LjmOF2hZKA8thrDNNL2aRASToZu8FsmczX9NjFX2EfA6V6eJDLr5B6Lo4dnWESqpkZ4gdjVdiKjsDtb29M9z13ER0/Q5YxLfsfY65NznB6sl2nSSZTnN/zixo99YFIXmJ0oYDSZ3WJoNtRB+pByp0IHYRFzQwGb5TDyc/kWw88AzhGQsEWdY+95ab5ws6Wc8X9CQK1XLM7dm7xPXc1I95mHDMS4J4LF2OZ0ZVMy/Wr7bLnwAR/cKcbtk X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;2:kxj1VxLxStiq7ZnpaOO3kYRZfY/QLfwmKzIlAQFx1tQjwJ2JevuCT8Bh9vT/24kDcxijjCpJ9sbYXLFyolqhMd3xAdFcVZCqY4INOqEsqbACyH+55nGuhLWjDjdyFBFEZFucd2GxdqjIC9MxRWb7dOiMfpBFUt+iGQ/ODrtJrZ2PaShSc/W/dhm0f35H79F5;3:ngH68Fz3YGDRLBxZBsJgoGgtXHaiPcsh6WTiKBoqKbPH+uxibzahhzS2dRh2YhhpOJ6UFXm35BjxNTZIqnU1MwLuiJl0lO1L7h9HN4Emoy9opFszFs7RRYDHAASAP13MSytpLQ8HN1PoP41jxwmxQF0sCZt+MRS37Ttx0V9bWOO2lUrMcDgZ9V15vizWSL/O0EYatbCEo6+wUEQoQVs18F4y7BDv3UYDx5Req4WyD0hfEXleyoxIH8cuY7xGrL8+ X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:CY1PR0301MB1291; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;25:4DsTzfjIkc6iHHLI8Ix9vo5GXRzfM3aQA2gEaWYHFjSEsq9LKst1eiEjYG0QffcoZ+/5yQ5ajb3AFRj7Hzs53/Il9K8cr/DT3eB1HhG/MjCbwph91W4HNz3OEcUtX2rESzCVTeVnWt0nAg/HYUZavTNYJJqbNZx4AIdJSS6sNvCB+Hhhj7AM9c6ETeuUt20ZUCYz65hwMF4vyfJjaL3kOQdm7UwU4EnvfIceqvqNYiKW6Kf+5XmSlcspJ5LeW5fA3xyd+PeZaQUsLgOMymoZh0/hzhh9uqm6HHDB/IL+xjUcx9tiGHFGr5BjZWY0meUAazyes9728EzgzncELwZKJ9Vb3jsZrucDnjmXBboswp8GaLicaA1strpqEgkT7snQ9iQsFfTVYXMY+UU8htNI5ByyfVsiwgHm4sQaeAsB3K9NL7OfMkzO/GJlCO2pldAlRHvsVv/LgAJngayvQypwW9hz7EucA4SlV4CeDmoHskfyfHMqHqviOb6iMtDr7WgFuyTRmIqa4tCbv/0WnI7sLIh3VxHowGwHFXYtU/nYTziUXUIWk0bfy50gjQzvEQmAN5huFQ3l4yHPTfzpBJjBvDEFArUvFNa/3dtkf2BIznsK6CnAUX8jID7TQJdZ44GmM9fSCJHbG34sK/2Ld9sTMA==;20:kDhJMF+nyz4s+HhOQhXlfa4ZscSNo6VjuMbIXSyA93mRUYI3MwXWS4NRVUnduB4ey4wTY+q+xgKwKMQs0rO+o1LPm5Y6ImOLR+Q/qZMwvJNX/mduwRlyccMtr9KkbbOwPve0UkLOjsIqYNxbJm5bpwLtQpaELgPl+0eI2ItzDdw= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;4:z0rC9WT73jEwRp4/CQS8WiOpi0WxTxLjp2fw/B6qU6brizIMmf5ny5MtMW8jlb8hGFyKQWcA4cXDx8wlL2pKqcen29+H9pP+xndqf/vIBP1yVbCHHjR/qiYseS6bm1wI8c/uljqbJ0GGOlrQ4hBxZpm696Ur9gWRukVEduUU2bEP1ZSqpL/zVIxvu9bQzY1odGXaUg/E19apMxhjUbnafcNzhDxWDlh8hpAjnaBul345hwhtKVdoGBEL7POMdhqzVUV6Aq5RERPjSe0O5jT8n4seoOn6zeDAHdsrRJOjQpcDX+9AaFE0b12lAQ/vOluo77GIKZx9hxv7SuLNkPeBru9K02ZCKlgDKEyoEch/PYIOMD+7p6NjUcOx7s7IRzfvY7CjxEpl4Hjr8w+G2XwPV2Zt2KhrRHbFg7luk54UXvR5eLdjgaugcPWmc52ii5F+eqd5MzAR9xEhqodBZeWSEg== X-Forefront-PRVS: 08978A8F5C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1291;23:IwdP4yNHRKgvnFwHcPyWbOOAnGcieSDMiRkVs2Q?= =?us-ascii?Q?zs3ot7uGkhSWOLXBpSwa9/sYKNEhJ7PaA4Sh/3q2R+KVndKzKRruGvSG0hp/?= =?us-ascii?Q?u0owPmmFphxkdPhF6+kQapiDIvbP/qk+NvlWQDC05zCwIQWEbbV7uFNS68H9?= =?us-ascii?Q?+/fSMWWfRf08vrmUvTusK6yOW1x825ONk2kF9uWWb28Rb71EPnbp3XBfhDhv?= =?us-ascii?Q?GGY0uVgM5TOElP+wqRYiJoFD5Vre76dDDqcDLMQnTAx+zcO/VrViyXTEPB5Q?= =?us-ascii?Q?d6/Km7zfQv+I0mrDAPBUSKO840akzi9ZYo0Mf6j+MHXdZoEYFUW0kY+WFNIA?= =?us-ascii?Q?au4Oln0tmULvXwM17GrNuAM1qmcF+Z3Ck4guaaiOgP3ZwVnQXlQ9JTKBoF7g?= =?us-ascii?Q?mcRtq+QkYSfexhmoGfHMyu358YyzRakn6XwlPIXEY0VChnYyR/wdiuZo4naN?= =?us-ascii?Q?U2veAISc3C+pxAIcDO07OTg9bZzv/0JsgOZN1sYaeOUDX1zZ7pMTMhr/Hnhp?= =?us-ascii?Q?CLDvD3McaXxOQ3qP5lrdpwZG5rRjOEpsL5YDfYBaHZscD4ti3opO9rSB3kyi?= =?us-ascii?Q?+QBUk0Sc3Vylb4E19r7kaWIoISJz8gollz98Rf/W8cFoVJjMXQzZcT12Tx6P?= =?us-ascii?Q?rPVYoQSyysBWlX5FosyWHj90h1v15+s2EWSTVzupSpve8e/0fMk5idL4uA61?= =?us-ascii?Q?HzkDFLoeLarGSOhV4CD1c3MTys76pcweoZ9DGB0bM6XpC3D0tmlnDsPmniBM?= =?us-ascii?Q?/XoId/kmqkPmcbmwQKE1qlpNSo3CyjtOnxifN8M1sW25K5egyXxrMIFnLUyW?= =?us-ascii?Q?Vtz7yehr7Hdul3Tu3TS7fr1YLvgU1y5XENNdy7yTEOskr+WSYAa2hG2tg9LN?= =?us-ascii?Q?yHWwyFKOrGy9eEfrDMz+yAVzUFq2+0IIPL86psSsoTxamEZhrX6WZW2MJYPg?= =?us-ascii?Q?0Qs4uC3NtSZyjoWzUKrk3RqRwzWgByfeL/p3TdPmLO83y/+OD5H23R+ripHf?= =?us-ascii?Q?jb1tKdiaQN9rr/37CA3cP7mpp1TRsj8/zeV7FkNNuGspL36BYsfUc1fUhXPB?= =?us-ascii?Q?q1T2O0p24DnQdjNRNTvAhb4xUatSTEQkp2ySIhA6rB+tSWef8wjp9K2//N5J?= =?us-ascii?Q?lvvFFf0nqJqM5XudEM9k9URyXdrXbScd5yA0qEQ9/OdU1Vsbl8OqDoDiKRKG?= =?us-ascii?Q?voRTVOtrf6UsR8gIOKcehKVjve+97CwdIo0YCDUFhIrggRGU2RiP7oIoNd8x?= =?us-ascii?Q?l6etpl92SahK2vI4k0HA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;5:XsOXyyFUUXMuBQABBSTAPOOFkskRs1h5PflgwSCQNIXV/bisSFni/yotOUJMb/fP3uafFci/PJ8zG7/dHdyHXYVL6JHklHe1MklZraEt/4Nyb2SV3HAOqRCufw/H3S/2mVh0X55i5rA9rhEuyigjJQ==;24:Hf2SJqYqP4Q9/Lnt4aHyuEsTIJ07apzwZn7jJAhbIt9mmImsm0XfsEu7eQrZUgla8QvHmTQCnlYcjKwrABB+7cv9jnZmp2A4Ycbqq1DBSNk=;20:MdvUNsUuqqxKQ5AOd7eLZovi5Y2GUCDoqpTgvRP1RLGWna8dHNCtXWspZNZ/ZX5nTT9GrXX8WkpHjtPmjpLHR0dW9CcbpSzzWaR7AGftX+luOTLEf/qctxoF6XcCY8W3ZMq90zT1Fa6nD4ByzCJtXDX+3/9h+2fQNzIwhUVwTXY= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2016 17:18:33.9910 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1291 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > > Signed-off-by: Thor Thayer > --- [snip] > + > +void socfpga_init_arria10_ocram_ecc(void) > +{ > + struct device_node *np; > + int ret; > + > + /* Find the OCRAM EDAC device tree node */ > + np = of_find_compatible_node(NULL, NULL, "altr,socfpga-a10-ocram-ecc"); > + if (!np) { > + pr_err("Unable to find socfpga-a10-ocram-ecc\n"); > + return; > + } > + > + ret = altr_init_a10_ecc_block(np, A10_SYSMGR_ECC_INTSTAT_OCRAM, > + ALTR_A10_OCRAM_ECC_EN_CTL, 0); I think this is a no-no, you shouldn't be making a call directly into the driver from here. BR, Dinh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Subject: Re: [PATCH 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup Date: Wed, 30 Mar 2016 12:11:14 -0500 Message-ID: References: <1459351668-14622-1-git-send-email-tthayer@opensource.altera.com> <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: <1459351668-14622-7-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org Cc: bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 30 Mar 2016, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > From: Thor Thayer > > Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > > Signed-off-by: Thor Thayer > --- [snip] > + > +void socfpga_init_arria10_ocram_ecc(void) > +{ > + struct device_node *np; > + int ret; > + > + /* Find the OCRAM EDAC device tree node */ > + np = of_find_compatible_node(NULL, NULL, "altr,socfpga-a10-ocram-ecc"); > + if (!np) { > + pr_err("Unable to find socfpga-a10-ocram-ecc\n"); > + return; > + } > + > + ret = altr_init_a10_ecc_block(np, A10_SYSMGR_ECC_INTSTAT_OCRAM, > + ALTR_A10_OCRAM_ECC_EN_CTL, 0); I think this is a no-no, you shouldn't be making a call directly into the driver from here. BR, Dinh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dinguyen@opensource.altera.com (Dinh Nguyen) Date: Wed, 30 Mar 2016 12:11:14 -0500 Subject: [PATCH 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup In-Reply-To: <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> References: <1459351668-14622-1-git-send-email-tthayer@opensource.altera.com> <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 30 Mar 2016, tthayer at opensource.altera.com wrote: > From: Thor Thayer > > Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > > Signed-off-by: Thor Thayer > --- [snip] > + > +void socfpga_init_arria10_ocram_ecc(void) > +{ > + struct device_node *np; > + int ret; > + > + /* Find the OCRAM EDAC device tree node */ > + np = of_find_compatible_node(NULL, NULL, "altr,socfpga-a10-ocram-ecc"); > + if (!np) { > + pr_err("Unable to find socfpga-a10-ocram-ecc\n"); > + return; > + } > + > + ret = altr_init_a10_ecc_block(np, A10_SYSMGR_ECC_INTSTAT_OCRAM, > + ALTR_A10_OCRAM_ECC_EN_CTL, 0); I think this is a no-no, you shouldn't be making a call directly into the driver from here. BR, Dinh