From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbcEPIHo (ORCPT ); Mon, 16 May 2016 04:07:44 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:57575 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbcEPIHm (ORCPT ); Mon, 16 May 2016 04:07:42 -0400 X-IronPort-AV: E=Sophos;i="5.24,626,1454972400"; d="scan'208";a="218397452" Date: Mon, 16 May 2016 10:07:39 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: Lee Jones , Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() In-Reply-To: <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2016, SF Markus Elfring wrote: > >> * Change an error message. > > > > Why? Is dev_err needed? > > I interpreted Lee's response in this way. > https://lkml.org/lkml/2016/1/11/104 OK. He didn't ask for the message to be changed though. It's a bit unfortunate that it now takes up multiple lines. And I believe it also prints redundant information. Perhaps he will have some further thoughts on the matter. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 16 May 2016 08:07:39 +0000 Subject: Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Message-Id: List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> In-Reply-To: <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Lee Jones , Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On Mon, 16 May 2016, SF Markus Elfring wrote: > >> * Change an error message. > > > > Why? Is dev_err needed? > > I interpreted Lee's response in this way. > https://lkml.org/lkml/2016/1/11/104 OK. He didn't ask for the message to be changed though. It's a bit unfortunate that it now takes up multiple lines. And I believe it also prints redundant information. Perhaps he will have some further thoughts on the matter. julia