On Mon, 12 Feb 2018, Dan Carpenter wrote: > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > Fix the dup_sg_table function to initialize the dma_address of the new > > sg list entries instead of the source dma_address entries. > > > > Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") > > Signed-off-by: Liam Mark > > How did you find this bug? What are the user visible effects of this > bug? I'm probably going to ask you to send a v2 patch with a new > changelog depending on the answers to these questions. I noticed the bug when reading through the code, I havenąt seen any visible effects of this bug. >From looking at the code I donąt see any obvious ways that this bug would introduce any issues with the current code base. Liam Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project