From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757731AbaCDUre (ORCPT ); Tue, 4 Mar 2014 15:47:34 -0500 Received: from smtp0.kfki.hu ([148.6.0.25]:53417 "EHLO smtp0.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757466AbaCDUra (ORCPT ); Tue, 4 Mar 2014 15:47:30 -0500 Date: Tue, 4 Mar 2014 21:47:26 +0100 (CET) From: Jozsef Kadlecsik To: "Jason A. Donenfeld" cc: netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ip_set: remove extraneous log message In-Reply-To: <1393794424-1887-1-git-send-email-Jason@zx2c4.com> Message-ID: References: <1393794424-1887-1-git-send-email-Jason@zx2c4.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2 Mar 2014, Jason A. Donenfeld wrote: > This code path is hit everytime a new network namespace is created, > which means it runs everytime I start Chromium, resulting in needless > noise in my logs. This message doesn't add very much at all, and isn't > triggered at the correct place anyway, so this patch simply removes it. > > Signed-off-by: Jason A. Donenfeld > --- > net/netfilter/ipset/ip_set_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c > index de770ec..283f197 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -1945,7 +1945,6 @@ ip_set_net_init(struct net *net) > return -ENOMEM; > inst->is_deleted = 0; > rcu_assign_pointer(inst->ip_set_list, list); > - pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL); > return 0; > } A similar patch has already been applied to the ipset git tree and going to be submitted this week. Thanks your patch anyway. Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary