From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753054AbaFDNjm (ORCPT ); Wed, 4 Jun 2014 09:39:42 -0400 Received: from www.linutronix.de ([62.245.132.108]:37136 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbaFDNjl (ORCPT ); Wed, 4 Jun 2014 09:39:41 -0400 Date: Wed, 4 Jun 2014 15:39:32 +0200 (CEST) From: Thomas Gleixner To: Nikita Yushchenko cc: Grant Likely , Rob Herring , Benjamin Herrenschmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lugovskoy@dev.rtsoft.ru Subject: Re: [PATCH 01/21] irq: add devres version of OF IRQ mapping routines In-Reply-To: <1401880402-30091-2-git-send-email-nyushchenko@dev.rtsoft.ru> Message-ID: References: <1401880402-30091-1-git-send-email-nyushchenko@dev.rtsoft.ru> <1401880402-30091-2-git-send-email-nyushchenko@dev.rtsoft.ru> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Jun 2014, nyushchenko@dev.rtsoft.ru wrote: > From: Nikita Yushchenko > > Many drivers use devres to manage their resources, and at the same time > use irq_of_parse_and_map() / irq_dispose_mapping(). This creates problem > on driver unload paths and on error paths: > - it is invalid to call irq_dispose_mapping() while IRQ handler is still > installed, > - devres moves removal of IRQ handler out of driver, > - without explicit devres support for IRQ mapping, irq_dispose_mapping() > stays in driver and thus gets called while IRQ handler is still > installed. > > This patch adds devm_irq_create_of_mapping() and devm_irq_of_parse_and_map() > routines to be used by drivers for correct release of resources. > > Signed-off-by: Nikita Yushchenko Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 01/21] irq: add devres version of OF IRQ mapping routines Date: Wed, 4 Jun 2014 15:39:32 +0200 (CEST) Message-ID: References: <1401880402-30091-1-git-send-email-nyushchenko@dev.rtsoft.ru> <1401880402-30091-2-git-send-email-nyushchenko@dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1401880402-30091-2-git-send-email-nyushchenko-jFhMxQ4mL6a2X5qOxWx28w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nikita Yushchenko Cc: Grant Likely , Rob Herring , Benjamin Herrenschmidt , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lugovskoy-jFhMxQ4mL6a2X5qOxWx28w@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 4 Jun 2014, nyushchenko-jFhMxQ4mL6a2X5qOxWx28w@public.gmane.org wrote: > From: Nikita Yushchenko > > Many drivers use devres to manage their resources, and at the same time > use irq_of_parse_and_map() / irq_dispose_mapping(). This creates problem > on driver unload paths and on error paths: > - it is invalid to call irq_dispose_mapping() while IRQ handler is still > installed, > - devres moves removal of IRQ handler out of driver, > - without explicit devres support for IRQ mapping, irq_dispose_mapping() > stays in driver and thus gets called while IRQ handler is still > installed. > > This patch adds devm_irq_create_of_mapping() and devm_irq_of_parse_and_map() > routines to be used by drivers for correct release of resources. > > Signed-off-by: Nikita Yushchenko Reviewed-by: Thomas Gleixner -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html