From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932155AbaKMIoP (ORCPT ); Thu, 13 Nov 2014 03:44:15 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60133 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbaKMIoN (ORCPT ); Thu, 13 Nov 2014 03:44:13 -0500 X-IronPort-AV: E=Sophos;i="5.07,375,1413237600"; d="scan'208";a="87847989" Date: Thu, 13 Nov 2014 09:43:58 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() In-Reply-To: <5463C373.5050804@users.sourceforge.net> Message-ID: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c > index 697876b..359f169 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c > +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c [...] > -exit: > +cleanup2: > + kfree(eFuseWord); > + > +cleanup1: > kfree(efuseTbl); > > - kfree(eFuseWord); > +exit: > + ; > } You are not using the most recent version of the code. The issue has already been fixed. Concretely, this part of the function now reads: exit: kfree(eFuseWord); eFuseWord_failed: kfree(efuseTbl); julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 13 Nov 2014 08:43:58 +0000 Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() Message-Id: List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> In-Reply-To: <5463C373.5050804@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c > index 697876b..359f169 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c > +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c [...] > -exit: > +cleanup2: > + kfree(eFuseWord); > + > +cleanup1: > kfree(efuseTbl); > > - kfree(eFuseWord); > +exit: > + ; > } You are not using the most recent version of the code. The issue has already been fixed. Concretely, this part of the function now reads: exit: kfree(eFuseWord); eFuseWord_failed: kfree(efuseTbl); julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Thu, 13 Nov 2014 09:43:58 +0100 (CET) Subject: [Cocci] [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() In-Reply-To: <5463C373.5050804@users.sourceforge.net> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c > index 697876b..359f169 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c > +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c [...] > -exit: > +cleanup2: > + kfree(eFuseWord); > + > +cleanup1: > kfree(efuseTbl); > > - kfree(eFuseWord); > +exit: > + ; > } You are not using the most recent version of the code. The issue has already been fixed. Concretely, this part of the function now reads: exit: kfree(eFuseWord); eFuseWord_failed: kfree(efuseTbl); julia