From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478AbaKPP5R (ORCPT ); Sun, 16 Nov 2014 10:57:17 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:14405 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966AbaKPP5P (ORCPT ); Sun, 16 Nov 2014 10:57:15 -0500 X-IronPort-AV: E=Sophos;i="5.07,397,1413237600"; d="scan'208";a="88610183" Date: Sun, 16 Nov 2014 16:56:58 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Ingo Molnar , Steven Rostedt , LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: Re: [PATCH 1/1] kernel-trace: Deletion of an unnecessary check before the function call "iput" In-Reply-To: <5468ABBD.6000903@users.sourceforge.net> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5468ABBD.6000903@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Nov 2014 14:46:28 +0100 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > kernel/trace/trace_uprobe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 33ff6a2..ec002c0 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -552,8 +552,7 @@ error: > return ret; > > fail_address_parse: > - if (inode) > - iput(inode); > + iput(inode); There are jumps to fail_address_parse where the value of inode can only be NULL. julia > > pr_info("Failed to parse address or file.\n"); > > -- > 2.1.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sun, 16 Nov 2014 15:56:58 +0000 Subject: Re: [PATCH 1/1] kernel-trace: Deletion of an unnecessary check before the function call "iput" Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5468ABBD.6000903@users.sourceforge.net> In-Reply-To: <5468ABBD.6000903@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr On Sun, 16 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Nov 2014 14:46:28 +0100 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > kernel/trace/trace_uprobe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 33ff6a2..ec002c0 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -552,8 +552,7 @@ error: > return ret; > > fail_address_parse: > - if (inode) > - iput(inode); > + iput(inode); There are jumps to fail_address_parse where the value of inode can only be NULL. julia > > pr_info("Failed to parse address or file.\n"); > > -- > 2.1.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Sun, 16 Nov 2014 16:56:58 +0100 (CET) Subject: [Cocci] [PATCH 1/1] kernel-trace: Deletion of an unnecessary check before the function call "iput" In-Reply-To: <5468ABBD.6000903@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5468ABBD.6000903@users.sourceforge.net> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Sun, 16 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Nov 2014 14:46:28 +0100 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > kernel/trace/trace_uprobe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 33ff6a2..ec002c0 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -552,8 +552,7 @@ error: > return ret; > > fail_address_parse: > - if (inode) > - iput(inode); > + iput(inode); There are jumps to fail_address_parse where the value of inode can only be NULL. julia > > pr_info("Failed to parse address or file.\n"); > > -- > 2.1.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >