From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751012AbaK0SNg (ORCPT ); Thu, 27 Nov 2014 13:13:36 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:39843 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbaK0SNe (ORCPT ); Thu, 27 Nov 2014 13:13:34 -0500 X-IronPort-AV: E=Sophos;i="5.07,471,1413237600"; d="scan'208";a="90793678" Date: Thu, 27 Nov 2014 19:13:10 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Anisse Astier , Corentin Chary , Darren Hart , Ike Panhc , Jonathan Woithe , Mattia Dongili , platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() In-Reply-To: <5473AD39.9010309@users.sourceforge.net> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547389A6.9090106@users.sourceforge.net> <3842367.ojrMxTW2rH@path> <5473AD39.9010309@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Nov 2014, SF Markus Elfring wrote: > >> This issue was detected by using the Coccinelle software. > > > > What script was used ? > > A semantic patch approach which I published on the mailing lists in March > is in action on my software development system for a while. > > > > Is it in scripts/coccinelle ? > > Not yet. > > I hope that the involved update suggestions got sufficient positive feedback > to integrate five scripts there. The current scripts are very complicated, involving the interaction between multiple scripts and a database, and I think they are not very suitable for make coccicheck. Also, the idea of removing the null checks is not appropriate in all contexts. Perhaps it could be possible to add a script to the Linux kernel that handles a number of common cases for which removing the null test is widely considered to be desirable. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 27 Nov 2014 18:13:10 +0000 Subject: Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547389A6.9090106@users.sourceforge.net> <3842367.ojrMxTW2rH@path> <5473AD39.9010309@users.sourceforge.net> In-Reply-To: <5473AD39.9010309@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Anisse Astier , Corentin Chary , Darren Hart , Ike Panhc , Jonathan Woithe , Mattia Dongili , platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Mon, 24 Nov 2014, SF Markus Elfring wrote: > >> This issue was detected by using the Coccinelle software. > > > > What script was used ? > > A semantic patch approach which I published on the mailing lists in March > is in action on my software development system for a while. > > > > Is it in scripts/coccinelle ? > > Not yet. > > I hope that the involved update suggestions got sufficient positive feedback > to integrate five scripts there. The current scripts are very complicated, involving the interaction between multiple scripts and a database, and I think they are not very suitable for make coccicheck. Also, the idea of removing the null checks is not appropriate in all contexts. Perhaps it could be possible to add a script to the Linux kernel that handles a number of common cases for which removing the null test is widely considered to be desirable. julia