Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Fix duplicate conditional branch

[Julia Lawall <julia.lawall@lip6.fr>]

On Tue, 3 Mar 2015, Vaishali Thakkar wrote:

> On Tue, Mar 3, 2015 at 5:52 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > On Tue, 3 Mar 2015, Vaishali Thakkar wrote:
> >
> >> Replace duplicate branch with correct value. This branch
> >> is supposed to work for low thresh value.
> >
> > How did you find the problem?
>
> From git log. I was looking for git log of driver rtl8192e for that setup_timer
> problem and saw that someone sent a patch for this. And as rtl8192u and
> rtl8192e follows the same structure, I just looked at file of this driver. And
> this problem for rtl8192u was still there. So, I just sent a patch.
>
> Also, while changing this code I found that rtl8192u is not using any macro and
> rtl8192e was using one useless macro. So, I sent a patch for it also.

Good work :)

julia

> > julia
> >
> >> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> >> ---
> >>  drivers/staging/rtl8192u/r8192U_dm.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> >> index 7199616..5a01b7d 100644
> >> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> >> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> >> @@ -1628,8 +1628,8 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev, u32 dm_type,
> >>               dm_digtable.rssi_low_thresh = dm_value;
> >>       } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> >>               dm_digtable.rssi_high_power_highthresh = dm_value;
> >> -     } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> >> -             dm_digtable.rssi_high_power_highthresh = dm_value;
> >> +     } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
> >> +             dm_digtable.rssi_high_power_lowthresh = dm_value;
> >>       } else if (dm_type == DIG_TYPE_ENABLE) {
> >>               dm_digtable.dig_state           = DM_STA_DIG_MAX;
> >>               dm_digtable.dig_enable_flag     = true;
> >> --
> >> 1.9.1
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1bdb9ff234b262793c0537cc9e11cf087202e61a.1425367678.git.vthakkar1994%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
>
>
> --
> Vaishali
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAK-LDbKcVLuoedmX-HJxaeR9ZkY9ZNXdx%2Bj7xzu1kx3%2BpmuyXA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>