Re: [PATCH 01/32] do_fork(): Rename 'stack_size' argument to reflect actual use

From: David Rientjes <rientjes@google.com>
To: josh@joshtriplett.org
Cc: Alex Dowad <alexinbeijing@gmail.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Rik van Riel <riel@redhat.com>,
	Vladimir Davydov <vdavydov@parallels.com>
Subject: Re: [PATCH 01/32] do_fork(): Rename 'stack_size' argument to reflect actual use
Date: Fri, 13 Mar 2015 16:21:29 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1503131619500.7827@chino.kir.corp.google.com> (raw)
In-Reply-To: <20150313230354.GA11522@cloud>

On Fri, 13 Mar 2015, josh@joshtriplett.org wrote:

> On Fri, Mar 13, 2015 at 08:04:16PM +0200, Alex Dowad wrote:
> > The 'stack_size' argument is never used to pass a stack size. It's only used when
> > forking a kernel thread, in which case it is an argument which should be passed
> > to the 'main' function which the kernel thread executes. Hence, rename it to
> > 'kthread_arg'.
> 
> That's not the only use of stack_size.  Take a look at the clone2 system
> call (very minimally documented in the clone manpage) and the
> implementation of copy_thread on ia64, which does use stack_size in the
> non-kthread path.
> 

Exactly, and it seems like Alex just disregarded this early feedback when 
this was first raised that suggested it just be named "arg" and to comment 
the individual usage in the functions that get called with the formal.