From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751869AbbEDRdF (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 May 2015 13:33:05 -0400
Received: from mga11.intel.com ([192.55.52.93]:51881 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751065AbbEDRc7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 May 2015 13:32:59 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,366,1427785200"; 
   d="scan'208";a="566045218"
Date: Mon, 4 May 2015 10:31:23 -0700 (PDT)
From: Vikas Shivappa <vikas.shivappa@intel.com>
X-X-Sender: vikas@vshiva-Udesk
To: Peter Zijlstra <peterz@infradead.org>
cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>, vikas.shivappa@intel.com,
        linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
        tglx@linutronix.de, mingo@kernel.org, tj@kernel.org,
        matt.fleming@intel.com, will.auld@intel.com, peter.zijlstra@intel.com,
        h.peter.anvin@intel.com, kanaka.d.juvva@intel.com
Subject: Re: [PATCH 2/7] x86/intel_rdt: Adds support for Class of service
 management
In-Reply-To: <20150502183822.GG3007@worktop.Skamania.guest>
Message-ID: <alpine.DEB.2.10.1505041030480.6658@vshiva-Udesk>
References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-3-git-send-email-vikas.shivappa@linux.intel.com> <20150502183822.GG3007@worktop.Skamania.guest>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Sat, 2 May 2015, Peter Zijlstra wrote:

> On Fri, May 01, 2015 at 06:36:36PM -0700, Vikas Shivappa wrote:
>> +static inline bool cat_supported(struct cpuinfo_x86 *c)
>
> Is search and replace really that hard?
>
>> +/*
>> +* Called with the rdt_group_mutex held.
>> +*/
>
> Whitespace damaged and pointless comment.
>
>> +static int rdt_free_closid(struct intel_rdt *ir)
>> +{
>> +
>
> superfluous whitespace
>
>> +	lockdep_assert_held(&rdt_group_mutex);
>> +
>> +	WARN_ON(!ccmap[ir->clos].cgrp_count);
>> +	ccmap[ir->clos].cgrp_count--;
>> +	if (!ccmap[ir->clos].cgrp_count)
>> +		clear_bit(ir->clos, rdtss_info.closmap);
>> +
>> +	return 0;
>> +}
>
>
> These patches really are very sloppy..

Will resend the updated patch - most of the changes here are removed in next 
patch.

Thanks,
Vikas

>