From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbbETUpt (ORCPT ); Wed, 20 May 2015 16:45:49 -0400 Received: from mga09.intel.com ([134.134.136.24]:63167 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755011AbbETUpn (ORCPT ); Wed, 20 May 2015 16:45:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,466,1427785200"; d="scan'208";a="732674734" Date: Wed, 20 May 2015 13:43:58 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, Matt Fleming , "Auld, Will" , peter.zijlstra@intel.com, h.peter.anvin@intel.com, "Juvva, Kanaka D" , mtosatti@redhat.com Subject: Re: [PATCH 5/7] x86/intel_rdt: Software Cache for IA32_PQR_MSR In-Reply-To: Message-ID: References: <1431370976-31115-1-git-send-email-vikas.shivappa@linux.intel.com> <1431370976-31115-6-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 May 2015, Thomas Gleixner wrote: > On Wed, 20 May 2015, Vikas Shivappa wrote: >> On Fri, 15 May 2015, Thomas Gleixner wrote: >>>> -static DEFINE_PER_CPU(struct intel_cqm_state, cqm_state); >>>> +DEFINE_PER_CPU(struct intel_pqr_state, pqr_state); >>> >>> With CONFIG_PERF=n and CONFIG_CGROUP_RDT=y the linker will fail. >> >> copy from Makefile below - >> obj-$(CONFIG_CPU_SUP_INTEL) += perf_event_intel_rapl.o >> perf_event_intel_cqm.o >> >> should work with CONFIG_PERF_EVENTS=n and CGROUP_RDT=y ? > > Groan. Did you try to compile it? Certainly not. of course I did compile successfully after I changed PERF_EVENTS=n and RDT=y in the .config. sorry, my reason was wrong though. What I had not noticed was the .config is simply added to enabling CONFIG_PERF_EVENTS=y even though i disable it by editing .config. Thats because x86 is selecting it. So PERF_EVENTS cant be disabled on x86 and RDT is only in x86 && SUP_INTEL. How did you configure CONFIG_PERF_EVENTS=n and CGROUP_RDT=y and see the error ? Thanks, Vikas > > Simply because the whole section which contains perf_event* object > files is conditional on > > ifdef CONFIG_PERF_EVENTS > > I'm starting to get really grumpy and tired of your attitude. > > Thanks, > > tglx > > >