From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754645AbbGXUJV (ORCPT ); Fri, 24 Jul 2015 16:09:21 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:33551 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754564AbbGXUJU (ORCPT ); Fri, 24 Jul 2015 16:09:20 -0400 Date: Fri, 24 Jul 2015 13:09:17 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Vlastimil Babka cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , Greg Thelen , "Aneesh Kumar K.V" , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Naoya Horiguchi Subject: Re: [RFC v2 2/4] mm: unify checks in alloc_pages_node family of functions In-Reply-To: <1437749126-25867-2-git-send-email-vbabka@suse.cz> Message-ID: References: <1437749126-25867-1-git-send-email-vbabka@suse.cz> <1437749126-25867-2-git-send-email-vbabka@suse.cz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jul 2015, Vlastimil Babka wrote: > Perform the same debug checks in alloc_pages_node() as are done in > alloc_pages_exact_node() and __alloc_pages_node() by making the latter > function the inner core of the former ones. > > Change the !node_online(nid) check from VM_BUG_ON to VM_WARN_ON since it's not > fatal and this patch may expose some buggy callers. > > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by kanga.kvack.org (Postfix) with ESMTP id A21A76B0253 for ; Fri, 24 Jul 2015 16:09:20 -0400 (EDT) Received: by pdjr16 with SMTP id r16so18443391pdj.3 for ; Fri, 24 Jul 2015 13:09:20 -0700 (PDT) Received: from mail-pd0-x22f.google.com (mail-pd0-x22f.google.com. [2607:f8b0:400e:c02::22f]) by mx.google.com with ESMTPS id tx6si23117880pab.40.2015.07.24.13.09.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 13:09:19 -0700 (PDT) Received: by pdjr16 with SMTP id r16so18443281pdj.3 for ; Fri, 24 Jul 2015 13:09:19 -0700 (PDT) Date: Fri, 24 Jul 2015 13:09:17 -0700 (PDT) From: David Rientjes Subject: Re: [RFC v2 2/4] mm: unify checks in alloc_pages_node family of functions In-Reply-To: <1437749126-25867-2-git-send-email-vbabka@suse.cz> Message-ID: References: <1437749126-25867-1-git-send-email-vbabka@suse.cz> <1437749126-25867-2-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , Greg Thelen , "Aneesh Kumar K.V" , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Naoya Horiguchi On Fri, 24 Jul 2015, Vlastimil Babka wrote: > Perform the same debug checks in alloc_pages_node() as are done in > alloc_pages_exact_node() and __alloc_pages_node() by making the latter > function the inner core of the former ones. > > Change the !node_online(nid) check from VM_BUG_ON to VM_WARN_ON since it's not > fatal and this patch may expose some buggy callers. > > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org