From: Brian Austin <brian.austin@cirrus.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
brian.austin@cirrus.com, Paul.Handrigan@cirrus.com,
lgirdwood@gmail.com, broonie@kernel.org
Subject: Re: [PATCH] ASoC: Add info callback for SX_TLV controls
Date: Wed, 14 Oct 2015 09:03:04 -0500 [thread overview]
Message-ID: <alpine.DEB.2.10.1510140902060.10499@heelroid> (raw)
In-Reply-To: <1444825884-11827-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
> SX_TLV controls are intended for situations where the register behind
> the control has some non-zero value indicating the minimum gain
> and then gains increasing from there and eventually overflowing through
> zero.
>
> Currently every CODEC implementing these controls specifies the minimum
> as the non-zero value for the minimum and the maximum as the number of
> gain settings available.
>
> This means when the info callback subtracts the minimum value from the
> maximum value to calculate the number of gain levels available it is
> actually under reporting the available levels. This patch fixes this
> issue by adding a new snd_soc_info_volsw_sx callback that does not
> subtract the minimum value.
>
> Fixes: 1d99f2436d0d ("ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV")
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
Scales correctly on CS42L73 'Headphone Analog Playback Volume'
Tested-by: Brian Austin <brian.austin@cirrus.com>
next prev parent reply other threads:[~2015-10-14 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 12:31 [PATCH] ASoC: Add info callback for SX_TLV controls Charles Keepax
2015-10-14 13:10 ` Brian Austin
2015-10-14 14:03 ` Brian Austin [this message]
2015-10-16 16:41 ` Applied "ASoC: Add info callback for SX_TLV controls" to the asoc tree Mark Brown
2015-10-16 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1510140902060.10499@heelroid \
--to=brian.austin@cirrus.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.