All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: anthony.perard@citrix.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: "xl vcpu-set" not persistent across reboot?
Date: Mon, 6 Jun 2016 15:00:02 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606061459320.6721@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <20160606134244.GF14588@citrix.com>

On Mon, 6 Jun 2016, Wei Liu wrote:
> On Mon, Jun 06, 2016 at 02:07:46PM +0100, Stefano Stabellini wrote:
> > On Mon, 6 Jun 2016, Jan Beulich wrote:
> > > >>> On 03.06.16 at 18:35, <wei.liu2@citrix.com> wrote:
> > > > I got a patch ready.  But QEMU upstream refuses to start on the receiving end
> > > > with following error message:
> > > > 
> > > > qemu-system-i386: Unknown savevm section or instance 'cpu_common' 1
> > > > qemu-system-i386: load of migration failed: Invalid argument
> > > > 
> > > > With QEMU traditional HVM guest and PV guest, the guest works fine -- up
> > > > and running with all hot plugged cpus available.
> > > > 
> > > > So I think the relevant libxl information is transmitted but we also
> > > > need to fix QEMU upstream. But that's a separate issue.
> > 
> > For clarity, you have applied the patch below, started a VM, hotplugged
> > a vcpu, rebooted the guest, then migrated the VM, but at this point
> > there is an error?
> > 
> 
> Apply this patch, start a guest, hotplug some cpus, make them online
> inside guest, and xl migrate guest localhost.
> 
> You will see this in qemu log.
> 
> > What are the QEMU command line arguments at the receiving side? Are you
> > sure that the increased vcpu count is passed to the receiving end by
> > libxl? It looks like QEMU has been started passing the old vcpu count as
> > command line argument (-smp etc) at the receiving end.
> > 
> 
> The QEMU command line should be the same on the sending side.
> 
> The -smp 1,maxvcpus=4 (something like that).
> 
> Does that mean we need to somehow alter QEMU's command line?

Yes, that's right. The device state that we pass to QEMU is just the
state of the devices specified by the command line args.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-06 14:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  9:04 "xl vcpu-set" not persistent across reboot? Jan Beulich
2016-06-06 13:07 ` Stefano Stabellini
2016-06-06 13:42   ` Wei Liu
2016-06-06 14:00     ` Stefano Stabellini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-03  8:29 Jan Beulich
2016-06-03 13:41 ` Wei Liu
2016-06-03 14:42   ` Jan Beulich
2016-06-03 16:35     ` Wei Liu
2016-06-06  8:58       ` Jan Beulich
2016-06-06 17:18       ` Wei Liu
2016-06-06 17:20         ` Wei Liu
2016-06-06 17:34           ` Andrew Cooper
2016-06-07  8:30             ` Wei Liu
2016-06-14 16:34               ` Ian Jackson
2016-06-14 16:39                 ` Wei Liu
2016-06-14 16:57                   ` Ian Jackson
2016-06-14 16:59                     ` Andrew Cooper
2016-06-14 17:06                       ` Wei Liu
2016-06-14 17:03                     ` Wei Liu
2016-06-14 17:23                       ` Wei Liu
2016-06-14 17:35                     ` Anthony PERARD
2016-06-07  6:38         ` Jan Beulich
2016-06-07  8:27           ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1606061459320.6721@sstabellini-ThinkPad-X260 \
    --to=sstabellini@kernel.org \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.