Re: [PATCH raisin 1/4] components/xen: Actually disable rombios

From: Stefano Stabellini <sstabellini@kernel.org>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH raisin 1/4] components/xen: Actually disable rombios
Date: Tue, 14 Jun 2016 10:32:31 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606141032230.2878@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1465829063-22291-2-git-send-email-george.dunlap@citrix.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1872 bytes --]

On Mon, 13 Jun 2016, George Dunlap wrote:
> Commit 5fe3855 meant to disable rombios, but didn't.  This causes the following
> build failure:
> 
> gcc   -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
> -Wno-unused-but-set-variable -Wno-unused-local-typedefs
> -D__XEN_TOOLS__ -MMD -MF .rombios.o.d -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs  -DNDEBUG -Werror
> -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float
> -I/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/include
> -U__XEN_TOOLS__
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> -DENABLE_OVMF -DENABLE_ROMBIOS -DENABLE_SEABIOS  -c -o rombios.o rombios.c
> rombios.c: In function ‘rombios_load_roms’:
> rombios.c:103:39: error: ‘etherboot’ undeclared (first use in this function)
>                                        etherboot);
> 
> Disable rombios instead.
> 
> Reported-by: Holger Schramm <lists@schramm.by>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> CC: Stefano Stabellini <sstabellini@kernel.org>
> ---
>  components/xen | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/components/xen b/components/xen
> index 894d119..ea290aa 100644
> --- a/components/xen
> +++ b/components/xen
> @@ -45,7 +45,7 @@ function xen_build() {
>      export ETHERBOOT_NICS=""
>      ./configure --prefix=$PREFIX --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \
>          --disable-stubdom --disable-qemu-traditional \
> -        --enable-rombios $seabios_opt $ovmf_opt
> +        --disable-rombios $seabios_opt $ovmf_opt
>      $RAISIN_MAKE
>      $RAISIN_MAKE install DESTDIR="$INST_DIR"
>      unset ETHERBOOT_NICS
> -- 
> 2.1.4
> 

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel