From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [RFC 3/8] xen/arm: gic: split set_irq_properties Date: Wed, 22 Jun 2016 11:58:57 +0100 (BST) Message-ID: References: <1465318123-3090-1-git-send-email-julien.grall@arm.com> <1465318123-3090-4-git-send-email-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465318123-3090-4-git-send-email-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall Cc: sstabellini@kernel.org, wei.chen@arm.com, steve.capper@arm.com, xen-devel@lists.xen.org, shannon.zhao@linaro.org, shankerd@codeaurora.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCA3IEp1biAyMDE2LCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gVGhlIGNhbGxiYWNrIHNl dF9pcnFfcHJvcGVydGllcyB3aWxsIGNvbmZpZ3VyZSB0aGUgR0lDIGZvciBhIHNwZWNpZmljCj4g SVJRIHdpdGggdGhlIHR5cGUgYW5kIHRoZSBwcmlvcml0eS4KPiAKPiBJbiBhIGZvbGxvdy11cCBw YXRjaCwgWGVuIHdpbGwgY29uZmlndXJlIHRoZSB0eXBlIGFuZCB0aGUgcHJpb3JpdHkgYXQKPiBk aWZmZXJlbnQgc3RhZ2Ugb2YgdGhlIHJvdXRpbmcuIFNvIHNwbGl0IGl0IGluIDIgc2VwYXJhdGUg Y2FsbGJhY2tzLgo+IAo+IEF0IHRoZSBzYW1lIHRpbWUsIG1vdmUgdGhlIEFTU0VSVCB0byBjaGVj ayB0aGUgdmFsaWRpdHkgb2YgdGhlIHR5cGUgYW5kCj4gaWYgdGhlIGRlc2MtPmxvY2sgaXMgbG9j a2VkIGluIHRoZSBjb21tb24gY29kZSAoZ2ljLmMpLiBUaGlzIGlzIGJlY2F1c2UKPiB0aGUgY29u c3RyYWludCBhcmUgdGhlIHNhbWUgYmV0d2VlbiBHSUN2MiBhbmQgR0lDdjMsIGhvd2V2ZXIgdGhl IGRyaXZlcgo+IG9mIHRoZSBsYXR0ZXIgZGlkIG5vdCBjb250YWluIGFueSBzYW5pdHkgY2hlY2su Cj4gCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4K ClJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+ CgoKPiAgeGVuL2FyY2gvYXJtL2dpYy12Mi5jICAgICB8IDE5ICsrKysrKysrKysrKystLS0tLS0K PiAgeGVuL2FyY2gvYXJtL2dpYy12My5jICAgICB8IDE1ICsrKysrKysrKysrKy0tLQo+ICB4ZW4v YXJjaC9hcm0vZ2ljLmMgICAgICAgIHwgMjMgKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgeGVu L2luY2x1ZGUvYXNtLWFybS9naWMuaCB8ICA3ICsrKystLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCA0 MyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gvYXJtL2dpYy12Mi5jIGIveGVuL2FyY2gvYXJtL2dpYy12Mi5jCj4gaW5kZXggOTBiMDdiMy4u ZmEyYzVhNSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vZ2ljLXYyLmMKPiArKysgYi94ZW4v YXJjaC9hcm0vZ2ljLXYyLmMKPiBAQCAtMjAwLDE2ICsyMDAsMTIgQEAgc3RhdGljIHVuc2lnbmVk IGludCBnaWN2Ml9yZWFkX2lycSh2b2lkKQo+ICAgICAgcmV0dXJuIChyZWFkbF9naWNjKEdJQ0Nf SUFSKSAmIEdJQ0NfSUFfSVJRKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgZ2ljdjJfc2V0X2ly cV9wcm9wZXJ0aWVzKHN0cnVjdCBpcnFfZGVzYyAqZGVzYywKPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBwcmlvcml0eSkKPiArc3RhdGljIHZvaWQg Z2ljdjJfc2V0X2lycV90eXBlKHN0cnVjdCBpcnFfZGVzYyAqZGVzYykKPiAgewo+ICAgICAgdWlu dDMyX3QgY2ZnLCBhY3R1YWwsIGVkZ2ViaXQ7Cj4gICAgICB1bnNpZ25lZCBpbnQgaXJxID0gZGVz Yy0+aXJxOwo+ICAgICAgdW5zaWduZWQgaW50IHR5cGUgPSBkZXNjLT5hcmNoLnR5cGU7Cj4gIAo+ IC0gICAgQVNTRVJUKHR5cGUgIT0gSVJRX1RZUEVfSU5WQUxJRCk7Cj4gLSAgICBBU1NFUlQoc3Bp bl9pc19sb2NrZWQoJmRlc2MtPmxvY2spKTsKPiAtCj4gICAgICBzcGluX2xvY2soJmdpY3YyLmxv Y2spOwo+ICAgICAgLyogU2V0IGVkZ2UgLyBsZXZlbCAqLwo+ICAgICAgY2ZnID0gcmVhZGxfZ2lj ZChHSUNEX0lDRkdSICsgKGlycSAvIDE2KSAqIDQpOwo+IEBAIC0yMzQsNiArMjMwLDE2IEBAIHN0 YXRpYyB2b2lkIGdpY3YyX3NldF9pcnFfcHJvcGVydGllcyhzdHJ1Y3QgaXJxX2Rlc2MgKmRlc2Ms Cj4gICAgICAgICAgICAgIElSUV9UWVBFX0xFVkVMX0hJR0g7Cj4gICAgICB9Cj4gIAo+ICsgICAg c3Bpbl91bmxvY2soJmdpY3YyLmxvY2spOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBnaWN2Ml9z ZXRfaXJxX3ByaW9yaXR5KHN0cnVjdCBpcnFfZGVzYyAqZGVzYywKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgcHJpb3JpdHkpCj4gK3sKPiArICAgIHVu c2lnbmVkIGludCBpcnEgPSBkZXNjLT5pcnE7Cj4gKwo+ICsgICAgc3Bpbl9sb2NrKCZnaWN2Mi5s b2NrKTsKPiArCj4gICAgICAvKiBTZXQgcHJpb3JpdHkgKi8KPiAgICAgIHdyaXRlYl9naWNkKHBy aW9yaXR5LCBHSUNEX0lQUklPUklUWVIgKyBpcnEpOwo+ICAKPiBAQCAtOTE2LDcgKzkyMiw4IEBA IGNvbnN0IHN0YXRpYyBzdHJ1Y3QgZ2ljX2h3X29wZXJhdGlvbnMgZ2ljdjJfb3BzID0gewo+ICAg ICAgLmVvaV9pcnEgICAgICAgICAgICAgPSBnaWN2Ml9lb2lfaXJxLAo+ICAgICAgLmRlYWN0aXZh dGVfaXJxICAgICAgPSBnaWN2Ml9kaXJfaXJxLAo+ICAgICAgLnJlYWRfaXJxICAgICAgICAgICAg PSBnaWN2Ml9yZWFkX2lycSwKPiAtICAgIC5zZXRfaXJxX3Byb3BlcnRpZXMgID0gZ2ljdjJfc2V0 X2lycV9wcm9wZXJ0aWVzLAo+ICsgICAgLnNldF9pcnFfdHlwZSAgICAgICAgPSBnaWN2Ml9zZXRf aXJxX3R5cGUsCj4gKyAgICAuc2V0X2lycV9wcmlvcml0eSAgICA9IGdpY3YyX3NldF9pcnFfcHJp b3JpdHksCj4gICAgICAuc2VuZF9TR0kgICAgICAgICAgICA9IGdpY3YyX3NlbmRfU0dJLAo+ICAg ICAgLmRpc2FibGVfaW50ZXJmYWNlICAgPSBnaWN2Ml9kaXNhYmxlX2ludGVyZmFjZSwKPiAgICAg IC51cGRhdGVfbHIgICAgICAgICAgID0gZ2ljdjJfdXBkYXRlX2xyLAo+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vZ2ljLXYzLmMgYi94ZW4vYXJjaC9hcm0vZ2ljLXYzLmMKPiBpbmRleCBjOTM2 YzhhLi5jMjVmZTUwIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9naWMtdjMuYwo+ICsrKyBi L3hlbi9hcmNoL2FybS9naWMtdjMuYwo+IEBAIC00NzEsOCArNDcxLDcgQEAgc3RhdGljIGlubGlu ZSB1aW50NjRfdCBnaWN2M19tcGlkcl90b19hZmZpbml0eShpbnQgY3B1KQo+ICAgICAgICAgICAg ICAgTVBJRFJfQUZGSU5JVFlfTEVWRUwobXBpZHIsIDApKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZv aWQgZ2ljdjNfc2V0X2lycV9wcm9wZXJ0aWVzKHN0cnVjdCBpcnFfZGVzYyAqZGVzYywKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBwcmlvcml0eSkK PiArc3RhdGljIHZvaWQgZ2ljdjNfc2V0X2lycV90eXBlKHN0cnVjdCBpcnFfZGVzYyAqZGVzYykK PiAgewo+ICAgICAgdWludDMyX3QgY2ZnLCBhY3R1YWwsIGVkZ2ViaXQ7Cj4gICAgICB2b2lkIF9f aW9tZW0gKmJhc2U7Cj4gQEAgLTUxMiw2ICs1MTEsMTUgQEAgc3RhdGljIHZvaWQgZ2ljdjNfc2V0 X2lycV9wcm9wZXJ0aWVzKHN0cnVjdCBpcnFfZGVzYyAqZGVzYywKPiAgICAgICAgICAgICAgSVJR X1RZUEVfRURHRV9SSVNJTkcgOgo+ICAgICAgICAgICAgICBJUlFfVFlQRV9MRVZFTF9ISUdIOwo+ ICAgICAgfQo+ICsgICAgc3Bpbl91bmxvY2soJmdpY3YzLmxvY2spOwo+ICt9Cj4gKwo+ICtzdGF0 aWMgdm9pZCBnaWN2M19zZXRfaXJxX3ByaW9yaXR5KHN0cnVjdCBpcnFfZGVzYyAqZGVzYywKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgcHJpb3JpdHkp Cj4gK3sKPiArICAgIHVuc2lnbmVkIGludCBpcnEgPSBkZXNjLT5pcnE7Cj4gKwo+ICsgICAgc3Bp bl9sb2NrKCZnaWN2My5sb2NrKTsKPiAgCj4gICAgICAvKiBTZXQgcHJpb3JpdHkgKi8KPiAgICAg IGlmICggaXJxIDwgTlJfR0lDX0xPQ0FMX0lSUVMgKQo+IEBAIC0xNTQ3LDcgKzE1NTUsOCBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IGdpY19od19vcGVyYXRpb25zIGdpY3YzX29wcyA9IHsKPiAgICAg IC5lb2lfaXJxICAgICAgICAgICAgID0gZ2ljdjNfZW9pX2lycSwKPiAgICAgIC5kZWFjdGl2YXRl X2lycSAgICAgID0gZ2ljdjNfZGlyX2lycSwKPiAgICAgIC5yZWFkX2lycSAgICAgICAgICAgID0g Z2ljdjNfcmVhZF9pcnEsCj4gLSAgICAuc2V0X2lycV9wcm9wZXJ0aWVzICA9IGdpY3YzX3NldF9p cnFfcHJvcGVydGllcywKPiArICAgIC5zZXRfaXJxX3R5cGUgICAgICAgID0gZ2ljdjNfc2V0X2ly cV90eXBlLAo+ICsgICAgLnNldF9pcnFfcHJpb3JpdHkgICAgPSBnaWN2M19zZXRfaXJxX3ByaW9y aXR5LAo+ICAgICAgLnNlbmRfU0dJICAgICAgICAgICAgPSBnaWN2M19zZW5kX3NnaSwKPiAgICAg IC5kaXNhYmxlX2ludGVyZmFjZSAgID0gZ2ljdjNfZGlzYWJsZV9pbnRlcmZhY2UsCj4gICAgICAu dXBkYXRlX2xyICAgICAgICAgICA9IGdpY3YzX3VwZGF0ZV9sciwKPiBkaWZmIC0tZ2l0IGEveGVu L2FyY2gvYXJtL2dpYy5jIGIveGVuL2FyY2gvYXJtL2dpYy5jCj4gaW5kZXggZjI1MzgxZi4uMGZk N2U4YyAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vZ2ljLmMKPiArKysgYi94ZW4vYXJjaC9h cm0vZ2ljLmMKPiBAQCAtOTYsMTQgKzk2LDE3IEBAIHZvaWQgZ2ljX3Jlc3RvcmVfc3RhdGUoc3Ry dWN0IHZjcHUgKnYpCj4gICAgICBnaWNfcmVzdG9yZV9wZW5kaW5nX2lycXModik7Cj4gIH0KPiAg Cj4gLS8qCj4gLSAqIC0gZGVzYy5sb2NrIG11c3QgYmUgaGVsZAo+IC0gKiAtIGFyY2gudHlwZSBt dXN0IGJlIHZhbGlkIChpLmUgIT0gSVJRX1RZUEVfSU5WQUxJRCkKPiAtICovCj4gLXN0YXRpYyB2 b2lkIGdpY19zZXRfaXJxX3Byb3BlcnRpZXMoc3RydWN0IGlycV9kZXNjICpkZXNjLAo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBwcmlvcml0eSkKPiAr c3RhdGljIHZvaWQgZ2ljX3NldF9pcnFfdHlwZShzdHJ1Y3QgaXJxX2Rlc2MgKmRlc2MpCj4gK3sK PiArICAgIEFTU0VSVChzcGluX2lzX2xvY2tlZCgmZGVzYy0+bG9jaykpOwo+ICsgICAgQVNTRVJU KGRlc2MtPmFyY2gudHlwZSAhPSBJUlFfVFlQRV9JTlZBTElEKTsKPiArCj4gKyAgICBnaWNfaHdf b3BzLT5zZXRfaXJxX3R5cGUoZGVzYyk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGdpY19zZXRf aXJxX3ByaW9yaXR5KHN0cnVjdCBpcnFfZGVzYyAqZGVzYywgdW5zaWduZWQgaW50IHByaW9yaXR5 KQo+ICB7Cj4gLSAgICBnaWNfaHdfb3BzLT5zZXRfaXJxX3Byb3BlcnRpZXMoZGVzYywgcHJpb3Jp dHkpOwo+ICsgICAgZ2ljX2h3X29wcy0+c2V0X2lycV9wcmlvcml0eShkZXNjLCBwcmlvcml0eSk7 Cj4gIH0KPiAgCj4gIC8qIFByb2dyYW0gdGhlIEdJQyB0byByb3V0ZSBhbiBpbnRlcnJ1cHQgdG8g dGhlIGhvc3QgKGkuZS4gWGVuKQo+IEBAIC0xMjEsNyArMTI0LDggQEAgdm9pZCBnaWNfcm91dGVf aXJxX3RvX3hlbihzdHJ1Y3QgaXJxX2Rlc2MgKmRlc2MsIGNvbnN0IGNwdW1hc2tfdCAqY3B1X21h c2ssCj4gIAo+ICAgICAgZGVzYy0+aGFuZGxlci0+c2V0X2FmZmluaXR5KGRlc2MsIGNwdV9tYXNr KTsKPiAgCj4gLSAgICBnaWNfc2V0X2lycV9wcm9wZXJ0aWVzKGRlc2MsIHByaW9yaXR5KTsKPiAr ICAgIGdpY19zZXRfaXJxX3R5cGUoZGVzYyk7Cj4gKyAgICBnaWNfc2V0X2lycV9wcmlvcml0eShk ZXNjLCBwcmlvcml0eSk7Cj4gIH0KPiAgCj4gIC8qIFByb2dyYW0gdGhlIEdJQyB0byByb3V0ZSBh biBpbnRlcnJ1cHQgdG8gYSBndWVzdAo+IEBAIC0xNTMsNyArMTU3LDggQEAgaW50IGdpY19yb3V0 ZV9pcnFfdG9fZ3Vlc3Qoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHZpcnEsCj4gICAg ICBkZXNjLT5oYW5kbGVyID0gZ2ljX2h3X29wcy0+Z2ljX2d1ZXN0X2lycV90eXBlOwo+ICAgICAg c2V0X2JpdChfSVJRX0dVRVNULCAmZGVzYy0+c3RhdHVzKTsKPiAgCj4gLSAgICBnaWNfc2V0X2ly cV9wcm9wZXJ0aWVzKGRlc2MsIHByaW9yaXR5KTsKPiArICAgIGdpY19zZXRfaXJxX3R5cGUoZGVz Yyk7Cj4gKyAgICBnaWNfc2V0X2lycV9wcmlvcml0eShkZXNjLCBwcmlvcml0eSk7Cj4gIAo+ICAg ICAgcC0+ZGVzYyA9IGRlc2M7Cj4gICAgICByZXMgPSAwOwo+IGRpZmYgLS1naXQgYS94ZW4vaW5j bHVkZS9hc20tYXJtL2dpYy5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9naWMuaAo+IGluZGV4IGI5 MzFmOTguLmZmYmE0NjkgMTAwNjQ0Cj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9naWMuaAo+ ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZ2ljLmgKPiBAQCAtMzI5LDkgKzMyOSwxMCBAQCBz dHJ1Y3QgZ2ljX2h3X29wZXJhdGlvbnMgewo+ICAgICAgdm9pZCAoKmRlYWN0aXZhdGVfaXJxKShz dHJ1Y3QgaXJxX2Rlc2MgKmlycWQpOwo+ICAgICAgLyogUmVhZCBJUlEgaWQgYW5kIEFjayAqLwo+ ICAgICAgdW5zaWduZWQgaW50ICgqcmVhZF9pcnEpKHZvaWQpOwo+IC0gICAgLyogU2V0IElSUSBw cm9wZXJ0eSAqLwo+IC0gICAgdm9pZCAoKnNldF9pcnFfcHJvcGVydGllcykoc3RydWN0IGlycV9k ZXNjICpkZXNjLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50 IHByaW9yaXR5KTsKPiArICAgIC8qIFNldCBJUlEgdHlwZSAtIHR5cGUgaXMgdGFrZW4gZnJvbSBk ZXNjLT5hcmNoLnR5cGUgKi8KPiArICAgIHZvaWQgKCpzZXRfaXJxX3R5cGUpKHN0cnVjdCBpcnFf ZGVzYyAqZGVzYyk7Cj4gKyAgICAvKiBTZXQgSVJRIHByaW9yaXR5ICovCj4gKyAgICB2b2lkICgq c2V0X2lycV9wcmlvcml0eSkoc3RydWN0IGlycV9kZXNjICpkZXNjLCB1bnNpZ25lZCBpbnQgcHJp b3JpdHkpOwo+ICAgICAgLyogU2VuZCBTR0kgKi8KPiAgICAgIHZvaWQgKCpzZW5kX1NHSSkoZW51 bSBnaWNfc2dpIHNnaSwgZW51bSBnaWNfc2dpX21vZGUgaXJxbW9kZSwKPiAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgY3B1bWFza190ICpvbmxpbmVfbWFzayk7Cj4gLS0gCj4gMS45LjEKPiAK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg==