From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sstabellini@kernel.org>) id 1bXvV7-0002AO-5A
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 15:18:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sstabellini@kernel.org>) id 1bXvV1-0001Bl-4b
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 15:18:44 -0400
Received: from mail.kernel.org ([198.145.29.136]:37002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sstabellini@kernel.org>) id 1bXvV0-0001Ba-Up
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 15:18:39 -0400
Date: Thu, 11 Aug 2016 12:18:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
In-Reply-To: <CAFEAcA9yc01coB89Qxmk3pjeUj7zm0sX0XG74iisAZDYWVTcgA@mail.gmail.com>
Message-ID: <alpine.DEB.2.10.1608111208500.25028@sstabellini-ThinkPad-X260>
References: <1453724163-26353-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<CAFEAcA9yc01coB89Qxmk3pjeUj7zm0sX0XG74iisAZDYWVTcgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] Xen: fix converity warning of
 xen_pt_config_init()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefano Stabellini <sstabellini@kernel.org>, Cao jin <caoj.fnst@cn.fujitsu.com>

Well spotted, thanks Peter!

It looks OK and has passed my tests, I'll send it in the next pull
request.

On Thu, 11 Aug 2016, Peter Maydell wrote:
> Hi Stefano -- just a ping on this patch from January -- I have a feeling
> it maybe got lost in your change of email address?
> 
> (I noticed looking through coverity reports that this one was unfixed
> and found Cao Jin's patch in the list archive.)
> 
> thanks
> -- PMM
> 
> 
> On 25 January 2016 at 12:16, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> > emu_regs is a pointer, ARRAY_SIZE doesn't return what we expect.
> > Since the remaining message is enough for debugging, so just remove it.
> > Also tweaked the message a little.
> >
> > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> > ---
> >  hw/xen/xen_pt_config_init.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
> > index 81c6721..e505438 100644
> > --- a/hw/xen/xen_pt_config_init.c
> > +++ b/hw/xen/xen_pt_config_init.c
> > @@ -2047,9 +2047,8 @@ void xen_pt_config_init(XenPCIPassthroughState *s, Error **errp)
> >                  for (j = 0; regs->size != 0; j++, regs++) {
> >                      xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> >                      if (err) {
> > -                        error_append_hint(&err, "Failed to initialize %d/%zu"
> > -                                " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> > -                                j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> > +                        error_append_hint(&err, "Failed to init register %d"
> > +                                " offsets 0x%x in grp_type = 0x%x (%d/%zu)", j,
> >                                  regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> >                                  i, ARRAY_SIZE(xen_pt_emu_reg_grps));
> >                          error_propagate(errp, err);
> > --
> > 2.1.0
>