From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932468AbcHKMjw (ORCPT ); Thu, 11 Aug 2016 08:39:52 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:32885 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932393AbcHKMjt (ORCPT ); Thu, 11 Aug 2016 08:39:49 -0400 X-IronPort-AV: E=Sophos;i="5.28,505,1464645600"; d="scan'208";a="187435805" Date: Thu, 11 Aug 2016 14:39:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Lee Jones , kernel-janitors@vger.kernel.org, wsa@the-dreams.de, LKML Subject: Re: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add_child() In-Reply-To: <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> Message-ID: References: <80dc4486-01d1-df66-c9c2-b71ee2251251@users.sourceforge.net> <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Aug 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 11 Aug 2016 14:00:43 +0200 > > Delete an error message at the end while increasing the importance of > related information. > > Link: https://lkml.kernel.org/g/<20160809153615.GU5243@dell> > Suggested-by: Lee Jones > Signed-off-by: Markus Elfring > --- > > v5: Rebased on the source files from Linux next-20160809. > > Requested changes were applied. > > drivers/mfd/dm355evm_msp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c > index 86eca61..463f9e2e 100644 > --- a/drivers/mfd/dm355evm_msp.c > +++ b/drivers/mfd/dm355evm_msp.c > @@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > if (pdata) { > status = platform_device_add_data(pdev, pdata, pdata_len); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add platform_data\n"); > + dev_err(&pdev->dev, "can't add platform_data\n"); Isn't this message unnecessary? platform_device_add_data only fails on failure of kmemdup, which I assume ends up in kmalloc eventually and prints a backtrace on failure. The same is true of platform_device_add_resources below. julia > goto put_device; > } > } > @@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > status = platform_device_add_resources(pdev, &r, 1); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add irq\n"); > + dev_err(&pdev->dev, "can't add irq\n"); > goto put_device; > } > } > @@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > put_device: > platform_device_put(pdev); > - dev_err(&client->dev, "failed to add device %s\n", name); > return ERR_PTR(status); > } > > -- > 2.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 11 Aug 2016 12:39:35 +0000 Subject: Re: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add_child() Message-Id: List-Id: References: <80dc4486-01d1-df66-c9c2-b71ee2251251@users.sourceforge.net> <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> In-Reply-To: <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Lee Jones , kernel-janitors@vger.kernel.org, wsa@the-dreams.de, LKML On Thu, 11 Aug 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 11 Aug 2016 14:00:43 +0200 > > Delete an error message at the end while increasing the importance of > related information. > > Link: https://lkml.kernel.org/g/<20160809153615.GU5243@dell> > Suggested-by: Lee Jones > Signed-off-by: Markus Elfring > --- > > v5: Rebased on the source files from Linux next-20160809. > > Requested changes were applied. > > drivers/mfd/dm355evm_msp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c > index 86eca61..463f9e2e 100644 > --- a/drivers/mfd/dm355evm_msp.c > +++ b/drivers/mfd/dm355evm_msp.c > @@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > if (pdata) { > status = platform_device_add_data(pdev, pdata, pdata_len); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add platform_data\n"); > + dev_err(&pdev->dev, "can't add platform_data\n"); Isn't this message unnecessary? platform_device_add_data only fails on failure of kmemdup, which I assume ends up in kmalloc eventually and prints a backtrace on failure. The same is true of platform_device_add_resources below. julia > goto put_device; > } > } > @@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > status = platform_device_add_resources(pdev, &r, 1); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add irq\n"); > + dev_err(&pdev->dev, "can't add irq\n"); > goto put_device; > } > } > @@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > put_device: > platform_device_put(pdev); > - dev_err(&client->dev, "failed to add device %s\n", name); > return ERR_PTR(status); > } > > -- > 2.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >