From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754412AbcHaXOV (ORCPT ); Wed, 31 Aug 2016 19:14:21 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35105 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbcHaXOR (ORCPT ); Wed, 31 Aug 2016 19:14:17 -0400 Date: Wed, 31 Aug 2016 16:14:14 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Simon Guo cc: linux-mm@kvack.org, Alexey Klimov , Andrew Morton , Eric B Munson , Geert Uytterhoeven , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mel Gorman , Michal Hocko , Shuah Khan , Thierry Reding , Vlastimil Babka Subject: Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected. In-Reply-To: <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> Message-ID: References: <1472554781-9835-1-git-send-email-wei.guo.simon@gmail.com> <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2016, wei.guo.simon@gmail.com wrote: > From: Simon Guo > > This patch adds mlock() test for multiple invocation on > the same address area, and verify it doesn't mess the > rlimit mlock limitation. > Thanks for expanding mlock testing. I'm wondering if you are interested in more elaborate testing that doesn't only check what you are fixing, such as mlock(p + x, 40k) where x is < 20k? Would you also be willing to make sure that the rlimit is actually enforced when it's expected to? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f197.google.com (mail-ua0-f197.google.com [209.85.217.197]) by kanga.kvack.org (Postfix) with ESMTP id 632D86B0038 for ; Wed, 31 Aug 2016 19:14:17 -0400 (EDT) Received: by mail-ua0-f197.google.com with SMTP id i89so7695801uad.1 for ; Wed, 31 Aug 2016 16:14:17 -0700 (PDT) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by mx.google.com with ESMTPS id or6si2050628pab.77.2016.08.31.16.14.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Aug 2016 16:14:16 -0700 (PDT) Received: by mail-pa0-x235.google.com with SMTP id fu3so15135467pad.3 for ; Wed, 31 Aug 2016 16:14:16 -0700 (PDT) Date: Wed, 31 Aug 2016 16:14:14 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected. In-Reply-To: <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> Message-ID: References: <1472554781-9835-1-git-send-email-wei.guo.simon@gmail.com> <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Simon Guo Cc: linux-mm@kvack.org, Alexey Klimov , Andrew Morton , Eric B Munson , Geert Uytterhoeven , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mel Gorman , Michal Hocko , Shuah Khan , Thierry Reding , Vlastimil Babka On Tue, 30 Aug 2016, wei.guo.simon@gmail.com wrote: > From: Simon Guo > > This patch adds mlock() test for multiple invocation on > the same address area, and verify it doesn't mess the > rlimit mlock limitation. > Thanks for expanding mlock testing. I'm wondering if you are interested in more elaborate testing that doesn't only check what you are fixing, such as mlock(p + x, 40k) where x is < 20k? Would you also be willing to make sure that the rlimit is actually enforced when it's expected to? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org