All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Rehas Sachdeva <aquannie@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Remove unnecessary blank line
Date: Mon, 12 Sep 2016 12:17:20 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1609121216100.3049@hadrien> (raw)
In-Reply-To: <20160912100728.GA4810@toblerone>



On Mon, 12 Sep 2016, Rehas Sachdeva wrote:

> This patch fixes the checkpatch.pl warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index f4d9000..f6233ec 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
>  		reg_data =  _nbu2ss_readl(
>  			(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
>  		dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
> -
>  	}
>
>  	spin_lock(&udc->lock);

This looks like a good start :)

For this round, however, you should also submit the patch to the
maintainers of the file, as described here:

https://kernelnewbies.org/FirstKernelPatch#submit_a_patch

The tutorial was just updated with this information yesterday, so you may
have missed it, if you got started before.

julia


  reply	other threads:[~2016-09-12 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 10:07 [PATCH] staging: emxx_udc: Remove unnecessary blank line Rehas Sachdeva
2016-09-12 10:17 ` Julia Lawall [this message]
2016-09-12 10:24 ` [Outreachy kernel] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1609121216100.3049@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=aquannie@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.