From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6329929865196732416 X-Received: by 10.46.32.154 with SMTP id g26mr118116lji.3.1473831415944; Tue, 13 Sep 2016 22:36:55 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.28.93.130 with SMTP id r124ls66585wmb.1.gmail; Tue, 13 Sep 2016 22:36:55 -0700 (PDT) X-Received: by 10.194.119.196 with SMTP id kw4mr117079wjb.1.1473831415479; Tue, 13 Sep 2016 22:36:55 -0700 (PDT) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id a126si158096wmd.1.2016.09.13.22.36.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 22:36:55 -0700 (PDT) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.30,332,1470693600"; d="scan'208";a="193053883" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien.local) ([109.28.67.198]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Sep 2016 07:36:54 +0200 Date: Wed, 14 Sep 2016 07:36:53 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Gargi Sharma cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org Subject: Re: [Outreachy kernel] [PATCH v2] staging: octeon: remove multiple blank lines In-Reply-To: <20160913212001.3945-1-gs051095@gmail.com> Message-ID: References: <20160913212001.3945-1-gs051095@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Wed, 14 Sep 2016, Gargi Sharma wrote: > Correcting the commit message. Fixes the checkpatch issue Please don't use multiple blank lines. You made the wrong choice here. In the v2, there should be a commit message as though no one ever saw the previous version. Then under the --- you should say what has changed. It doesn't need to be very detailed. It could just be "v2: fixed the commit message". Then one can check that the current commit message is ok, and one knows that the patch code has not changed. julia > > Signed-off-by: Gargi Sharma > --- > drivers/staging/octeon/ethernet.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index 0bd5c18..ec8e424 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev) > return -EINVAL; > } > > - > cvm_oct_configure_common_hw(); > > cvmx_helper_initialize_packet_io_global(); > @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev) > } > } > > - > cvmx_pko_shutdown(); > > cvmx_ipd_free_ptr(); > -- > 2.9.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913212001.3945-1-gs051095%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >