From mboxrd@z Thu Jan  1 00:00:00 1970
From: julia.lawall@lip6.fr (Julia Lawall)
Date: Thu, 15 Sep 2016 08:03:56 +0200 (CEST)
Subject: [Cocci] Match #define in cocci
In-Reply-To: <CAHKzcEMih-YHeaaa6hp1-Hf3PUY7GDdqG90wL6zZwuMjaQv=-g@mail.gmail.com>
References: <CAHKzcEN9fcOk1HCar=u+htx=o61xF61VmbO9PeYPBaedTQYDcg@mail.gmail.com>
 <alpine.DEB.2.10.1609141615560.3033@hadrien>
 <CAHKzcEMih-YHeaaa6hp1-Hf3PUY7GDdqG90wL6zZwuMjaQv=-g@mail.gmail.com>
Message-ID: <alpine.DEB.2.10.1609150803290.6497@hadrien>
To: cocci@systeme.lip6.fr
List-Id: cocci@systeme.lip6.fr



On Thu, 15 Sep 2016, Waldemar Rymarkiewicz wrote:

> >
> > Could you send the exact semantic patch that you tried?  Coccinelle should
> > allos parsing #defines.
>
> Simply
>
> @@
> @@
> -#define pr_fmt(fmt) KBUILD_MODNAME
>
> works, but
>
> @@
> @@
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> fails  with
>
> Fatal error: exception Failure("minus: parse error: \n = File
> \"patches/1021-pr_fmt_undef.cocci\", line 4, column 38,  charpos =
> 59\n    around = '\"', whole content = #define pr_fmt(fmt)
> KBUILD_MODNAME \": \" fmt\n")
>
> but even if I want to match just
>
> @@
> @@
> -#define pr_fmt(fmt) KBUILD_MODNAME  fmt
>
> it also fails with
>
> Fatal error: exception Failure("minus: parse error: \n = File
> \"patches/1021-pr_fmt_undef.cocci\", line 4, column 0,  charpos = 21\n
>    around = '#define pr_fmt(', whole content = #define pr_fmt(fmt)
> KBUILD_MODNAME fmt\n")

OK, thanks I will look into it.  At least in the last case, that is not
the intended behavior.

julia