All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: outreachy-kernel@googlegroups.com, Ronald Rojas <ronladred@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
Date: Thu, 15 Sep 2016 14:37:51 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1609151436370.3045@hadrien> (raw)
In-Reply-To: <15778561.A1ImvO0lIj@wuerfel>



On Thu, 15 Sep 2016, Arnd Bergmann wrote:

> On Thursday, September 15, 2016 8:24:26 AM CEST Ronald Rojas wrote:
> > Fixes several of the checkpatch.pl warning
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Ronald Rojas <ronladred@gmail.com>
>
> In the subject line, please use "octeon" instead of "ethernet".

In general, you can't make up your own formula for creating the subject
line.  You have to see what others have done, because different subsystems
use different strategies.  To see what others have done, do:

git log --oneline filename.c

julia

>
> Did you build test this driver using a MIPS cross-compiler?
> I realize that it's just a whitespace change and it clearly
> won't break anything, but in general you should do some
> build testing before sending it out, and properly building
> this driver is a bit tricky.
>
> 	Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/15778561.A1ImvO0lIj%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2016-09-15 12:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 12:24 [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings Ronald Rojas
2016-09-15 12:29 ` [Outreachy kernel] " Arnd Bergmann
2016-09-15 12:37   ` Julia Lawall [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-09-14 14:34 Ronald Rojas
2016-09-14 14:36 ` [Outreachy kernel] " Julia Lawall
2016-09-14 16:55   ` Ronald Rojas
2016-09-14 19:10     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1609151436370.3045@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=arnd@arndb.de \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=ronladred@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.