All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Elizabeth Ferdman <gnudevliz@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
	 amsfield22@gmail.com, daniel.baluta@intel.com
Subject: Re: [Outreachy kernel] [PATCH] staging: i4l: move open brace to previous line
Date: Fri, 7 Oct 2016 07:23:12 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1610070722510.3074@hadrien> (raw)
In-Reply-To: <20161006214116.GA10879@localhost>



On Thu, 6 Oct 2016, Elizabeth Ferdman wrote:

> Fix checkpatch error "open brace should be on previous line" since only
> functions should have their opening brace on a new line.
>
> Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
> ---
>  drivers/staging/i4l/act2000/module.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 0573f51..4746a62 100644
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -19,8 +19,7 @@
>  #include <linux/slab.h>
>  #include <linux/init.h>
>
> -static unsigned short act2000_isa_ports[] =
> -{
> +static unsigned short act2000_isa_ports[] = {
>  	0x0200, 0x0240, 0x0280, 0x02c0, 0x0300, 0x0340, 0x0380,
>  	0xcfe0, 0xcfa0, 0xcf60, 0xcf20, 0xcee0, 0xcea0, 0xce60,
>  };

Not related to this patch, but could this array be const?

julia

> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161006214116.GA10879%40localhost.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2016-10-07  5:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 21:41 [PATCH] staging: i4l: move open brace to previous line Elizabeth Ferdman
2016-10-07  5:23 ` Julia Lawall [this message]
2016-10-07 23:13   ` [Outreachy kernel] " Elizabeth Ferdman
2016-10-08  6:02     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1610070722510.3074@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=amsfield22@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=gnudevliz@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.