From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6338844661403090944 X-Received: by 10.25.99.71 with SMTP id x68mr1511989lfb.28.1475910071515; Sat, 08 Oct 2016 00:01:11 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.46.1.96 with SMTP id 93ls192525ljb.21.gmail; Sat, 08 Oct 2016 00:01:10 -0700 (PDT) X-Received: by 10.46.32.17 with SMTP id g17mr1518085ljg.3.1475910070961; Sat, 08 Oct 2016 00:01:10 -0700 (PDT) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id w16si252207wmd.0.2016.10.08.00.01.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Oct 2016 00:01:10 -0700 (PDT) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.31,311,1473112800"; d="scan'208";a="196059711" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Oct 2016 09:01:10 +0200 Date: Sat, 8 Oct 2016 09:01:09 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Muraru Mihaela cc: Greg Kroah-Hartman , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: ks7010: Delete unnecessary return statement In-Reply-To: <20161008070001.GA2695@domino-MS-16Y1> Message-ID: References: <20161007215439.GA15407@domino-MS-16Y1> <20161008070001.GA2695@domino-MS-16Y1> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 8 Oct 2016, Muraru Mihaela wrote: > On Sat, Oct 08, 2016 at 08:04:58AM +0200, Julia Lawall wrote: > > > > > > On Sat, 8 Oct 2016, Mihaela Muraru wrote: > > > > > This is a patch to ks_hostif.c file that fixes up a checkpatch.pl > > > > > > WARNING: void function return statements are not generally useful. > > > > > > The 'return' statement is not useful here, because it is not necessary to be > > > forced the exit of the function. > > > > > > Like in this example: > > > > > > void funct() { > > > > > > if(condition) return; > > > > > > //do something; > > > > > > } > > > > The patch is OK, but I don't understand what you mean by thi example. > > This looks like a case where the return cannot be removed. > > > > julia > > Thank you for reply. > > It is an example when we can use 'return' from a void function, but > now I think that is too much information and I will send patch v2 > without it. Yes, that would be better, thanks. julia > > mihaela > > > > Signed-off-by: Mihaela Muraru > > > --- > > > drivers/staging/ks7010/ks_hostif.c | 8 -------- > > > 1 file changed, 8 deletions(-) > > > > > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > > > index 8798b63..5ae013b 100644 > > > --- a/drivers/staging/ks7010/ks_hostif.c > > > +++ b/drivers/staging/ks7010/ks_hostif.c > > > @@ -1933,7 +1933,6 @@ void hostif_sme_set_wep(struct ks_wlan_private *priv, int type) > > > break; > > > } > > > > > > - return; > > > } > > > > > > struct wpa_suite_t { > > > @@ -2122,7 +2121,6 @@ void hostif_sme_set_rsn(struct ks_wlan_private *priv, int type) > > > break; > > > > > > } > > > - return; > > > } > > > > > > static > > > @@ -2236,7 +2234,6 @@ void hostif_sme_mode_setup(struct ks_wlan_private *priv) > > > break; > > > } > > > > > > - return; > > > } > > > > > > static > > > @@ -2337,7 +2334,6 @@ void hostif_sme_powermgt_set(struct ks_wlan_private *priv) > > > } > > > hostif_power_mngmt_request(priv, mode, wake_up, receiveDTIMs); > > > > > > - return; > > > } > > > > > > static > > > @@ -2355,7 +2351,6 @@ void hostif_sme_sleep_set(struct ks_wlan_private *priv) > > > break; > > > } > > > > > > - return; > > > } > > > > > > static > > > @@ -2413,7 +2408,6 @@ void hostif_sme_set_key(struct ks_wlan_private *priv, int type) > > > &priv->wpa.key[2].rx_seq[0]); > > > break; > > > } > > > - return; > > > } > > > > > > static > > > @@ -2649,7 +2643,6 @@ void hostif_sme_task(unsigned long dev) > > > tasklet_schedule(&priv->sme_task); > > > } > > > } > > > - return; > > > } > > > > > > /* send to Station Management Entity module */ > > > @@ -2733,5 +2726,4 @@ int hostif_init(struct ks_wlan_private *priv) > > > void hostif_exit(struct ks_wlan_private *priv) > > > { > > > tasklet_kill(&priv->sme_task); > > > - return; > > > } > > > -- > > > 2.7.4 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161007215439.GA15407%40domino-MS-16Y1. > > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161008070001.GA2695%40domino-MS-16Y1. > For more options, visit https://groups.google.com/d/optout. >