From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932667AbcJULD1 (ORCPT ); Fri, 21 Oct 2016 07:03:27 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34097 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754737AbcJULD0 (ORCPT ); Fri, 21 Oct 2016 07:03:26 -0400 X-IronPort-AV: E=Sophos;i="5.31,376,1473112800"; d="scan'208";a="241764321" Date: Fri, 21 Oct 2016 13:03:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: SF Markus Elfring , Jiri Kosina , Geert Uytterhoeven , LKML , kernel-janitors@vger.kernel.org Subject: Re: FRV-setup: Clarification for "source code clean-up"? In-Reply-To: <20161021102237.GK4418@mwanda> Message-ID: References: <1405b16a-c470-531d-458d-fb6042b93230@users.sourceforge.net> <81f557b2-40f3-0625-331d-c5b115f1971c@users.sourceforge.net> <20161021075142.GS4469@mwanda> <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> <20161021092730.GJ4418@mwanda> <9944c3e8-f030-a500-682c-7a7c7a1f492b@users.sourceforge.net> <20161021102237.GK4418@mwanda> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus, If you want to do something that might be useful, you could look into the problem of missing checks for dma mapping failure. There is nice slide presenatation about the issue: http://www.slideshare.net/SamsungOSG/shuah-khan-dmamaperror The slides are from a few years ago, but I did a small test recently, and the problem seems to persist. This needs to be done slowly and carefully, because when there is a failure, you need to figure out what to do to clean up and what value to return. There is no point to clean up all of the other checkpatch errors in the file at the same time. Just stay on the problem at hand. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Fri, 21 Oct 2016 11:03:20 +0000 Subject: Re: FRV-setup: Clarification for "source code clean-up"? Message-Id: List-Id: References: <1405b16a-c470-531d-458d-fb6042b93230@users.sourceforge.net> <81f557b2-40f3-0625-331d-c5b115f1971c@users.sourceforge.net> <20161021075142.GS4469@mwanda> <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> <20161021092730.GJ4418@mwanda> <9944c3e8-f030-a500-682c-7a7c7a1f492b@users.sourceforge.net> <20161021102237.GK4418@mwanda> In-Reply-To: <20161021102237.GK4418@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: SF Markus Elfring , Jiri Kosina , Geert Uytterhoeven , LKML , kernel-janitors@vger.kernel.org Markus, If you want to do something that might be useful, you could look into the problem of missing checks for dma mapping failure. There is nice slide presenatation about the issue: http://www.slideshare.net/SamsungOSG/shuah-khan-dmamaperror The slides are from a few years ago, but I did a small test recently, and the problem seems to persist. This needs to be done slowly and carefully, because when there is a failure, you need to figure out what to do to clean up and what value to return. There is no point to clean up all of the other checkpatch errors in the file at the same time. Just stay on the problem at hand. julia