From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9brH-00056J-GX for qemu-devel@nongnu.org; Wed, 23 Nov 2016 13:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9brE-000268-Fw for qemu-devel@nongnu.org; Wed, 23 Nov 2016 13:01:23 -0500 Received: from mail.kernel.org ([198.145.29.136]:36160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9brE-00024Z-9l for qemu-devel@nongnu.org; Wed, 23 Nov 2016 13:01:20 -0500 Date: Wed, 23 Nov 2016 10:01:10 -0800 (PST) From: Stefano Stabellini In-Reply-To: <58358B5202000078001213E0@prv-mh.provo.novell.com> Message-ID: References: <58356D610200007800121289@prv-mh.provo.novell.com> <58356E480200007800121296@prv-mh.provo.novell.com> <27145c26bfa849779baa52deddd09294@AMSPEX02CL03.citrite.net> <58357F200200007800121344@prv-mh.provo.novell.com> <32f40702983e45cfabc3d40dc4a3522b@AMSPEX02CL03.citrite.net> <58358B5202000078001213E0@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 1/3] xen: fix quad word bufioreq handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: Paul Durrant , Anthony Perard , Stefano Stabellini , xen-devel , "qemu-devel@nongnu.org" On Wed, 23 Nov 2016, Jan Beulich wrote: > >>> On 23.11.16 at 11:45, wrote: > > No, if QEMU is using a default ioreq server (i.e. the legacy way of doing > > things) then it's vulnerable to the guest messing with the rings and I'd > > forgotten that migrated-in guests from old QEMUs also end up using the default > > server, so I guess this is a worthy checkt to make... although maybe it's > > best to just bail if the check fails, since it would indicate a malicious > > guest. > > Okay, that's basically the TBD note I have in the patch; I'll wait for > at least one of the qemu maintainers to voice their preference. I think we should just print an error and destroy_hvm_domain(false) or hw_error if the check fails. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 1/3] xen: fix quad word bufioreq handling Date: Wed, 23 Nov 2016 10:01:10 -0800 (PST) Message-ID: References: <58356D610200007800121289@prv-mh.provo.novell.com> <58356E480200007800121296@prv-mh.provo.novell.com> <27145c26bfa849779baa52deddd09294@AMSPEX02CL03.citrite.net> <58357F200200007800121344@prv-mh.provo.novell.com> <32f40702983e45cfabc3d40dc4a3522b@AMSPEX02CL03.citrite.net> <58358B5202000078001213E0@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9brF-0003rt-VU for xen-devel@lists.xenproject.org; Wed, 23 Nov 2016 18:01:22 +0000 In-Reply-To: <58358B5202000078001213E0@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Anthony Perard , xen-devel , Paul Durrant , Stefano Stabellini , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMyBOb3YgMjAxNiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPj4+IE9uIDIzLjExLjE2 IGF0IDExOjQ1LCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+IHdyb3RlOgo+ID4gTm8sIGlmIFFF TVUgaXMgdXNpbmcgYSBkZWZhdWx0IGlvcmVxIHNlcnZlciAoaS5lLiB0aGUgbGVnYWN5IHdheSBv ZiBkb2luZyAKPiA+IHRoaW5ncykgdGhlbiBpdCdzIHZ1bG5lcmFibGUgdG8gdGhlIGd1ZXN0IG1l c3Npbmcgd2l0aCB0aGUgcmluZ3MgYW5kIEknZCAKPiA+IGZvcmdvdHRlbiB0aGF0IG1pZ3JhdGVk LWluIGd1ZXN0cyBmcm9tIG9sZCBRRU1VcyBhbHNvIGVuZCB1cCB1c2luZyB0aGUgZGVmYXVsdCAK PiA+IHNlcnZlciwgc28gSSBndWVzcyB0aGlzIGlzIGEgd29ydGh5IGNoZWNrdCB0byBtYWtlLi4u IGFsdGhvdWdoIG1heWJlIGl0J3MgCj4gPiBiZXN0IHRvIGp1c3QgYmFpbCBpZiB0aGUgY2hlY2sg ZmFpbHMsIHNpbmNlIGl0IHdvdWxkIGluZGljYXRlIGEgbWFsaWNpb3VzIAo+ID4gZ3Vlc3QuCj4g Cj4gT2theSwgdGhhdCdzIGJhc2ljYWxseSB0aGUgVEJEIG5vdGUgSSBoYXZlIGluIHRoZSBwYXRj aDsgSSdsbCB3YWl0IGZvcgo+IGF0IGxlYXN0IG9uZSBvZiB0aGUgcWVtdSBtYWludGFpbmVycyB0 byB2b2ljZSB0aGVpciBwcmVmZXJlbmNlLgogCkkgdGhpbmsgd2Ugc2hvdWxkIGp1c3QgcHJpbnQg YW4gZXJyb3IgYW5kIGRlc3Ryb3lfaHZtX2RvbWFpbihmYWxzZSkgb3IKaHdfZXJyb3IgaWYgdGhl IGNoZWNrIGZhaWxzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRw czovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==